get_page_by_title: duplicate SQL query

[david.binda]

The r54234 has introduced a duplicate SQL query triggered for the get_page_by_title function, as it's executing the SQL query by passing the arguments for a WP_Query directly to the constructor of the class, and then triggering the WP_Query::get_posts() directly, instead of accessing the WP_Query::posts property.

See https://core.trac.wordpress.org/browser/trunk/src/wp-includes/post.php?rev=54320#L5790

[mukesh27]

Thanks @davidbinda. good cache.

r54234 is merge before some days in 6.1 milestone. Let's move to 6.1 for consideration. feel free to update milestone.

cc. @spacedmonkey @SergeyBiryukov

[spacedmonkey]

This patch was meant to be in WordPress 6.1.

[mukesh27]

@spacedmonkey thanks for the confirmation.

56721.diff​ LGTM.
commit added.

[spacedmonkey]

+1 to commit.

https://core.trac.wordpress.org/ticket/56721

[peterwilsoncc]

Thanks for the patch @davidbinda.

I've added a test in the ​linked pull request and will commit once the checks start passing.

[peterwilsoncc]

In 54377:

Posts, Post types: Prevent get_page_by_title() parsing query twice.

In get_page_by_title() access the populated WP_Query::posts property directly rather than via the WP_Query::get_posts() method. This removes unnecessary reprocessing of the query.

Follow up to [54234].

Props david.binda, mukesh27, spacedmonkey.
Fixes #56721.

Committed in https://core.trac.wordpress.org/changeset/54377 / 4a9ab59d91f463d7b9021183d0702723fad91c87

[milana_cap]

Worth mentioning in performance grouped Dev Note.

[spacedmonkey]

@milana_cap This is a bug introduced in 6.1 beta. So no need to mention it. We are already mentioning change to get_page_by_title in the dev note.

[milana_cap]

Thank you @spacedmonkey