Update the `imagesloaded` library

[desrosj]

Currently, version 4.1.4 of imagesloaded is bundled in Core. Version 5.0.0 is available, so the bundled version should be updated.

This was looked at initially as part of #56670, but there's a strange issue with grunt jsvalidate:build where the new version of the file does not pass the first time the task is run, but does on successive runs.

[desrosj]

The failure encountered:

Running "jsvalidate:build" (jsvalidate) task
Validating src/wp-includes/js/imagesloaded.min.js  
>> Line 6: Unexpected identifier
Encountered 2 errors.
Warning: Task "jsvalidate:build" failed. Use --force to continue.

Trac ticket: https://core.trac.wordpress.org/ticket/56731

[nazsabuz]

PR closed as it's not resolving the issue.

[cunadkat]

Hi,

Actully we don't need this library anymore. We can check if images are loaded or not with vanilla js. If that is okay. I can make the changes and raise PR

[desrosj]

The imagesloaded library was included in Core to be used in conjunction with the masonry library.

While vanilla JavaScript could be used to accomplish the same things in modern times, the intention here is to update this external library to the latest version in case someone is still utilizing it. Some basic scans of the ​plugin and ​theme directory show that a fair number of sites are still enqueuing this library.

Once an external library is included in WordPress Core, it very rarely is removed for backwards compatibility reasons.

[arnedb]

Hi @desrosj ,

How exactly did you create this bug?

I've tried running npm run build:dev a couple of times on a fresh copy, but I keep getting a good result:

Running "jsvalidate:build" (jsvalidate) task
451 files are valid.

[desrosj]

The bug I described only happens after attempting to update the dependency. Steps to reproduce:

• Update the imagesloaded dependency to 5.0.0 in the package.json file.
• Run npm install
• Run npm run build and observe the error.

Trac ticket: https://core.trac.wordpress.org/ticket/56731

[desrosj]

I've created a PR that demonstrates the problem: ​https://github.com/WordPress/wordpress-develop/actions/runs/4026712852/jobs/6921561752.

[costdev]

This ticket was discussed during the bug scrub. As 6.2 Beta 1 is in a few days, I'm moving this ticket to Future Release. If it's ready for commit before 6.2 Beta 1, feel free to re-milestone it for 6.2.

Additional props: @audrasjb

[shanemuir]

Hey, I wanted to maybe look into a patch a 'good first bug' since I have never contributed to WP before. I have been able to get the latest SVN repo running locally and re-produce this bug but since imagesloaded is a 3rd party package I am unsure on the steps to providing a patch. Can anyone give me any pointers on how to resolve this bug?

V5.0.0 is built with ES6 and it needs to be transpiled first to pass the jsvalidate task.

I added a babel task that transpiles it, this required adding grunt-babel as a dev dependency.

Trac ticket: https://core.trac.wordpress.org/ticket/56731

[valmedia2023]

When testing the test.js file I receive this message.
Build failed with 1 error:
error: Cannot find module 'ava' from '/' js 8.21 is not installed

[SergeyBiryukov]

Restoring the correct component and properties, please see ​The Bug Tracker (Trac) and ​Trac Workflow Keywords.

[SergeyBiryukov]

Related: #58645

[SergeyBiryukov]

Replying to desrosj:

The failure encountered:

Running "jsvalidate:build" (jsvalidate) task
Validating src/wp-includes/js/imagesloaded.min.js  
>> Line 6: Unexpected identifier
Encountered 2 errors.
Warning: Task "jsvalidate:build" failed. Use --force to continue.

This appears to be unblocked by [56247] / #58645.

[Hareesh Pillai]

After the removal of jsvalidate, I could successfully generate a build with imagesloaded v5.0.0

Also, noting that the version might need to be updated in script-loader.php file as well.

[desrosj]

In 56393:

External Libraries: Update imagesLoaded to version 5.0.0.

This release drops support for IE and moves to using ES6.

A full list of changes can be found on GitHub: ​https://github.com/desandro/imagesloaded/compare/v4.1.4...v5.0.0.

Props nazsabuz, arnedb, costdev, audrasjb, ahmedgeek , valmedia2023 , hareesh-pillai.
Fixes #56731.

Merged in https://core.trac.wordpress.org/changeset/56393.