![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png){kind=logo}
Opened 4 years ago
Closed 4 years ago
#56738 closed defect (bug) (fixed)
Use require_once instead of require to load block files
| Reported by: | aristath | Owned by: | desrosj |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.1 |
| Component: | Build/Test Tools | Version: | |
| Severity: | normal | Keywords: | has-patch commit |
| Cc: | Focuses: |
Description
In sync-stable-blocks.js we're compiling the contents of the require-dynamic-blocks.php file.
When doing that, we currently use require instead of require_once to load the block files.
We should change that in our sync script, in the context of loading files like that require_once makes more sense.
Change History (4)
This ticket was mentioned in PR #3409 on WordPress/wordpress-develop by aristath.
4 years ago
#1
- Keywords has-patch added
#3
@
4 years ago
- Keywords commit added
- Owner set to
- Status new → assigned
I think since [53688] is also a change in 6.1 that my preference is to correct this issue prior to release, especially since the resulting file introduced from this tooling update has not yet been included in a release.
The change makes sense to me and looks good.
Note:
See TracTickets
for help on using tickets.
In
sync-stable-blocks.jswe're compiling the contents of therequire-dynamic-blocks.phpfile.When doing that, we currently use
requireinstead ofrequire_onceto load the block files.Trac ticket: https://core.trac.wordpress.org/ticket/56738