Opened 2 years ago
Closed 2 years ago
#56738 closed defect (bug) (fixed)
Use require_once instead of require to load block files
Reported by: | aristath | Owned by: | desrosj |
---|---|---|---|
Milestone: | 6.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Build/Test Tools | Keywords: | has-patch commit |
Focuses: | Cc: |
Description
In sync-stable-blocks.js
we're compiling the contents of the require-dynamic-blocks.php
file.
When doing that, we currently use require
instead of require_once
to load the block files.
We should change that in our sync script, in the context of loading files like that require_once
makes more sense.
Change History (4)
This ticket was mentioned in PR #3409 on WordPress/wordpress-develop by aristath.
2 years ago
#1
- Keywords has-patch added
#2
@
2 years ago
- Component changed from General to Build/Test Tools
- Milestone changed from Awaiting Review to 6.1
#3
@
2 years ago
- Keywords commit added
- Owner set to desrosj
- Status changed from new to assigned
I think since [53688] is also a change in 6.1 that my preference is to correct this issue prior to release, especially since the resulting file introduced from this tooling update has not yet been included in a release.
The change makes sense to me and looks good.
Note: See
TracTickets for help on using
tickets.
In
sync-stable-blocks.js
we're compiling the contents of therequire-dynamic-blocks.php
file.When doing that, we currently use
require
instead ofrequire_once
to load the block files.Trac ticket: https://core.trac.wordpress.org/ticket/56738