WordPress.org

Make WordPress Core

Opened 12 years ago

Closed 12 years ago

#5674 closed task (blessed) (fixed)

TinyMCE 3.0 Final

Reported by: azaozz Owned by:
Milestone: 2.5 Priority: normal
Severity: normal Version:
Component: TinyMCE Keywords: needs-testing
Focuses: Cc:

Description

TinyMCE 3.0 is fast approaching release and has a lot of improvements (most under the hood). The API has changed a lot too and none of the WordPress customizations is working properly. However with help from TinyMCE's team, we should be able to make it a perfect match for WordPress.

This patch includes the standard configuration plus the "media" plugin necessary for supporting embedded video and the "safari" plugin. The wpautop php function has to be changed a bit too for this to work well. The tiny_mce_gzip.php is disabled - it needs changing but also it's much easier to test js files when they're not concatenated. I've managed to get the tabs working (not in IE yet), but good enough for testing.

In general, most of the "wordpress" plugin for TinyMCE has to be rewritten, tiny_mce_gzip.php needs changes, autosave.js needs changes and the css around the editor needs adjusting - mostly in Safari and Opera.

Attachments (10)

wpautop_obj.patch (947 bytes) - added by azaozz 12 years ago.
no-tabs.png (24.0 KB) - added by ryan 12 years ago.
No tabs
general-template.patch (768 bytes) - added by azaozz 12 years ago.
tinymce.zip (235.7 KB) - added by azaozz 12 years ago.
cleaned some files and added latest autosave plugin
tinymce_removed_files.diff (1.6 KB) - added by ryan 12 years ago.
Files to remove
tinymce_removed_files2.diff (1.7 KB) - added by azaozz 12 years ago.
Yes, they're all from the 2.x branch. I've added one more at the end.
tiny_mce-3.0_RC2 (6.5 KB) - added by azaozz 12 years ago.
TinyMCE-3.0_RC2
tmce3_extra.patch (14.5 KB) - added by azaozz 12 years ago.
tinymce_3.0-final.zip (231.1 KB) - added by azaozz 12 years ago.
tmce-popup-css.patch (2.2 KB) - added by azaozz 12 years ago.
Small cleanup of the popups css

Download all attachments as: .zip

Change History (29)

@azaozz
12 years ago

#2 @ryan
12 years ago

#5573 will need to be worked back in. I don't see tabs in FF2 on Mac. See screenshot.

@ryan
12 years ago

No tabs

#3 @azaozz
12 years ago

Yes, general-template.php needed small change. How are we going to proceed, shall we make patches against the tinymce directory, or..?

@azaozz
12 years ago

cleaned some files and added latest autosave plugin

#4 @ryan
12 years ago

(In [6632]) TinyMCE 3.0 RC1. First cut, eexpect regressions. Props azaozz. see #5674

#5 @ryan
12 years ago

Old files haven't been removed yet.

@ryan
12 years ago

Files to remove

#6 @ryan
12 years ago

Here's a list of possible files to remove. Should they all be removed?

@azaozz
12 years ago

Yes, they're all from the 2.x branch. I've added one more at the end.

#8 in reply to: ↑ 7 ; follow-up: @lloydbudd
12 years ago

Replying to lloydbudd:

Does TinyMCE 3 resolve #4521 WYSIWYG editor strips out line breaks in WebKit / Safari3?

It seems like it doesn't:
[ 1765800 WordPress: Editor strips paragraph breaks. That issues seems like a blocker for WP 2.5 release.

#9 @ryan
12 years ago

(In [6636]) Remove old tinymce files. see #5674

#10 @azaozz
12 years ago

TinyMCE 3.0 doesn't fully support Safari. See the compatibility chart:
http://wiki.moxiecode.com/index.php/TinyMCE:Compatibility
Hopefully by March it will have full support for the functions used in WordPress.

It also doesn't support the "usual" way of entering line breaks - Left Shift + Enter in FF/IE

@azaozz
12 years ago

TinyMCE-3.0_RC2

#11 in reply to: ↑ 8 @azaozz
12 years ago

Replying to lloydbudd:
TinyMCE 3.0_RC3 now supports Safari 3 perfectly, including entering a BR tag by Left Shift + Enter (like all other browsers).

#12 follow-up: @lloydbudd
12 years ago

azaozz, awesome! oh, but you tease as you haven't attached a patch.

#13 @azaozz
12 years ago

  • Keywords needs-testing added
  • Summary changed from TinyMCE 3.0_RC1 to TinyMCE 3.0 Final

TinyMCE 3.0 final + all plugins including first run of the "wordpress" plugin and overall integration. All bigger bugs in the integration are (hopefully) gone, still plenty of fine-tunning left. Needs more testing.

@azaozz
12 years ago

#14 @azaozz
12 years ago

Patch is too big again... Includes the shrunk version of TinyMCE (saves about 75KB).

#15 in reply to: ↑ 12 @azaozz
12 years ago

Replying to lloydbudd:

azaozz, awesome! oh, but you tease as you haven't attached a patch.

No point in adding RC3, 3.0 final just came out...

#16 follow-up: @ryan
12 years ago

(In [6694]) TinyMCE 3.0 Final from azaozz. see #5674

#17 in reply to: ↑ 16 @lloydbudd
12 years ago

Replying to ryan:

(In [6694]) TinyMCE 3.0 Final from azaozz. see #5674

Woohoo! Now, I have free rein to file bugs ;-)

azaozz, do you know why http://sourceforge.net/tracker/index.php?func=detail&aid=1765800&group_id=103281&atid=635682 hasn't been updated and closed?

#18 @ryan
12 years ago

(In [6696]) Remove old tinymce files. see #5674

@azaozz
12 years ago

Small cleanup of the popups css

#19 @azaozz
12 years ago

  • Resolution set to fixed
  • Status changed from new to closed

Completed.

Note: See TracTickets for help on using tickets.