Make WordPress Core

Opened 17 months ago

Closed 13 months ago

Last modified 12 months ago

#56743 closed enhancement (fixed)

Update jquery-migrate to version 3.4.0

Reported by: desrosj's profile desrosj Owned by: audrasjb's profile audrasjb
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: External Libraries Keywords: good-first-bug has-patch commit add-to-field-guide
Focuses: javascript Cc:

Description

A new version of jquery-migrate (3.4.0) is available.

A full list of changes in this release can be found on GitHub: https://github.com/jquery/jquery-migrate/compare/3.3.2...3.4.0.

Change History (24)

#1 @desrosj
17 months ago

Props to @malthert for originally reporting this in #56452.

#2 @abubakar89
16 months ago

@desrosj do I just update the version and create a pull request?

#3 @a4jp.com
16 months ago

Yes, please @abubakar89.

To whom it may concern,

Any chance of getting 3.4.0 in 6.1 as it's just a link change on your side and as jQuery Migrate is still in WordPress?

Or a warning removal at least:

/*Remove JQuery Migrate warning*/
function remove_jquery_migrate_notice() {
    $m= $GLOBALS['wp_scripts']->registered['jquery-migrate'];
    $m->extra['before'][]='temp_jm_logconsole = window.console.log; window.console.log=null;';
    $m->extra['after'][]='window.console.log=temp_jm_logconsole;';
}
add_action( 'init', 'remove_jquery_migrate_notice', 5 );

https://core.trac.wordpress.org/ticket/51812#comment:133

Last edited 16 months ago by a4jp.com (previous) (diff)

This ticket was mentioned in PR #3550 on WordPress/wordpress-develop by @stalukder03.


16 months ago
#4

  • Keywords has-patch added; needs-patch removed

#5 @stalukder03
16 months ago

  • Keywords needs-patch added; has-patch removed

Hi @desrosj & @a4jpcom

I have made a pull request with the updated jquery-migrate version 3.4.0

Here is the pull request link, https://github.com/WordPress/wordpress-develop/pull/3550

I didn't find that warning notice that was supposed to be deleted. Please let me know if anything needs to be done to make it perfect.

FYI, I just updated the scripts in this directory, /js/_enqueues/vendor/jquery/
Didn't run "grunt build". Please let me know if I needed to do that.

Regards,
Sajib

Last edited 16 months ago by stalukder03 (previous) (diff)

#6 @stalukder03
16 months ago

  • Focuses javascript added
  • Keywords has-patch needs-testing added; needs-patch removed

Keywords updated.

This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.


13 months ago

This ticket was mentioned in Slack in #core-test by mukeshpanchal27. View the logs.


13 months ago

#9 @mukesh27
13 months ago

This ticket was discussed in the recent bug scrub.

The PR looks solid to go! Can someone from testing team review this? @robinwpdeveloper @adeltahri

Props to @costdev

#10 @audrasjb
13 months ago

  • Keywords needs-testing removed
  • Owner set to audrasjb
  • Status changed from new to accepted

Hi,
I tested the PR, trying to produce potential issue with a default install, but everything went fine:

  • go to wp-admin, log in
  • create new posts, with the block editor, display them on front end
  • create new posts, with the classic editor, display them on front end
  • install a plugin from the repo (Yoast), navigate to a few screens
  • install a premium plugin (Gravity Forms), same
  • go to the site editor, edit a template part
  • generate an application password using My Profile screen


#11 @adeltahri
13 months ago

Hello,
I retested the RP, and everything works fine.

create new posts, with the block editor, and display them on the front end.
create a new woocommerce product, tested image zoom, and lightbox image on the front end.
Install the Contact Form 7 test on the front end
change the theme and retested the same option above.

#12 @robinwpdeveloper
13 months ago

I see there is merge conflict with the latest version.
We need to resolve the conflict first I guess.

After running: npm run grunt patch:https://patch-diff.githubusercontent.com/raw/WordPress/wordpress-develop/pull/3550.diff

1 out of 1 hunk FAILED -- saving rejects to file src/wp-includes/script-loader.php.rej

@audrasjb commented on PR #3550:


13 months ago
#13

Ah. Looks like your PR comes from your trunk branch @stalukder03, so I'm unable to resolve the current conflicts. Would you like to open a new PR for this change, please?

@stalukder03 commented on PR #3550:


13 months ago
#14

Hi @audrasjb
Accidentally it gets merged instead of creating a new PR. FYI, I am new to core contributions as well as GitHub actions. I am really sorry for this type of mistake.

@audrasjb commented on PR #3550:


13 months ago
#15

Thanks for resolving the issue!

#16 @audrasjb
13 months ago

I imported jQuery Migrate on my side and I get the exact same diff so the PR looks good.

Also, I tested this change with a small set of plugins from the repository and it works fine on my side.

#17 @mahbubshovan
13 months ago


✅ create new posts, with the block editor, display them on front end -

Dashboard - https://d.pr/i/XVWaIm
Frontend - https://d.pr/i/IfZjKp

✅ create new posts, with the classic editor, display them on front end

Dashboard - https://d.pr/i/chQkEZ
Frontend - https://d.pr/i/9FBVJb

✅ install a plugin from the repo (Yoast), navigate to a few screens

Dashboard - https://d.pr/i/qtqqVy

✅ install a premium plugin (Gravity Forms), same

Dashboard - https://d.pr/i/vilkuD
Frontend - https://d.pr/i/z7ZFfa

✅ go to the site editor, edit a template part

Dashboard - https://d.pr/i/tqT25R
Frontend - https://d.pr/i/V2IyWH

✅ generate an application password using My Profile screen

Dashboard - https://d.pr/i/zhboGu

I have tested as per the above comments and found no issues with the patch. So we are good to go.

#18 @audrasjb
13 months ago

  • Keywords needs-dev-note added

Thanks for the tests!
I think we're good to go 👍

#19 @audrasjb
13 months ago

  • Keywords commit added

Let's commit this update now :)

#20 @audrasjb
13 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 55237:

External Libraries: Update jQuery Migrate to version 3.4.0.

A full list of changes in this release can be found upstream on the jQuery Migrate GitHub repository:
https://github.com/jquery/jquery-migrate/compare/3.3.2...3.4.0.

Props desrosj, audrasjb, a4jpcom, stalukder03, mukesh27, adeltahri, robinwpdeveloper, mahbubshovan.
Fixes #56743.

#22 @milana_cap
12 months ago

  • Keywords add-to-field-guide added

@audrasjb this seems like just a mention in the Field guide, hence the add-to-field-guide label. Did you have more in mind by adding needs-dev-note or were you simply unaware of the field guide label?

#23 @audrasjb
12 months ago

No, non, I'm aware but it's a mistake ;)

#24 @milana_cap
12 months ago

  • Keywords needs-dev-note removed
Note: See TracTickets for help on using tickets.