Use consistent, coding standard compliant naming for category ID variables

[hilayt24]

In "app/public/wp-admin/includes/taxonomy.php" while scanning I found the following errors and warnings.

189 | ERROR   | Variable "$cat_ID" is not in valid snake_case format, try "$cat_i_d"
 191 | ERROR   | Variable "$cat_ID" is not in valid snake_case format, try "$cat_i_d"
 191 | WARNING | Found: ==. Use strict comparisons (=== or !==).
 196 | ERROR   | Variable "$cat_ID" is not in valid snake_case format, try "$cat_i_d"

WordPress Version : 6.0.2
PHPCS Standard : WordPress-Core

[hilayt24]

I fixed the PHPCS errors and checked the changes in the site also.

[viralsampat]

I have added condition and resolved PHPCS errors.

[desrosj]

Related: [52958].

[robinwpdeveloper]

Thanks everyone who added patch.

Patch: https://core.trac.wordpress.org/attachment/ticket/56754/56754.diff
I am not sure if we need the empty check or not.
Also !empty should be ! empty to maintain the coding standard if I am not wrong.

Patch: https://core.trac.wordpress.org/attachment/ticket/56754/%2356754.patch
Looks straight forward to me and good.

[tanazmasaba]

Hi, I have searched $cat_ID throughout the full project in my local setup and I have found this in 3 different files, and total 13 occurrences.

Here are the file locations:

1. wordpress-develop/src/wp-admin/includes/taxonomy.php
2. wordpress-develop/src/wp-includes/deprecated.php
3. wordpress-develop/src/wp-includes/taxonomy.php

I think it would be better if we could fix in all 3 files.

Screenshot: ​https://d.pr/i/gf7c6l

[robinwpdeveloper]

Hi @costdev can you help us moving this ticket forward?

Trac ticket: https://core.trac.wordpress.org/ticket/56754

[costdev]

Hi @robinwpdeveloper, thanks for the ping!

I agree that #56754.patch is more straightforward, as the other patch contains a condition and unrelated inline comments.

Thanks for the PR which verified no tests were broken by the changes!

I've left ​a review noting that we can't change function parameter casing due to named parameters in PHP 8, which are case-sensitive.

Can you update the PR to remove the changes in src/wp-includes/deprecated.php and src/wp-includes/taxonomy.php?

Other than that, I think the PR is good to go.

Thanks @costdev
Changes are made as per feedback.

[robinwpdeveloper]

Changes are made as per requested.
I think we are good to go now.

[SergeyBiryukov]

Replying to costdev:

I've left ​a review noting that we can't change function parameter casing due to named parameters in PHP 8, which are case-sensitive.

That's correct, but as noted in the ​PHP 8.0 dev note, WordPress does not support named parameters at this time:

Using named parameters when calling WordPress functions and class methods is explicitly not supported and highly discouraged until this audit can be completed, as during the audit, parameter names are subject to change without notice. When this audit has been completed, it will be announced in a future developer note.

See tickets #51553, #55327, #55650, #56788 for continued work on this.

So I think we can include those parameter renamings here too.

[SergeyBiryukov]

In 55190:

Coding Standards: Rename the $cat_ID variable to $cat_id in wp_update_category().

This resolves a few WPCS warnings:

Variable "$cat_ID" is not in valid snake_case format, try "$cat_i_d"

Follow-up to [2695], [4490], [52958].

Props hilayt24, viralsampat, desrosj, robinwpdeveloper, tanazmasaba, costdev, SergeyBiryukov.
See #56754.

Thanks for the PR! Merged in r55190.

[costdev]

@SergeyBiryukov I wasn't aware of that! Thanks for the info!

[SergeyBiryukov]

In 55334:

Coding Standards: Rename the remaining $cat_ID variables to $cat_id.

This resolves a few WPCS warnings:

Variable "$cat_ID" is not in valid snake_case format, try "$cat_i_d"

Affected functions:

• wp_delete_category()
• get_category_rss_link()
• get_catname()

Follow-up to [836], [2068], [2551], [2695], [6365], [10959], [52958], [55190].

Fixes #56754.