Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 3 years ago

#56782 closed task (blessed) (fixed)

PHPUnit tests: Add/improve @covers annotations for WP 6.2

Reported by: pbearne Owned by: hellofromTonya
Priority: normal Milestone: 6.2
Component: Build/Test Tools Version: 4.8
Severity: normal Keywords: has-patch php8 has-unit-tests
Cc: Focuses: coding-standards

Description (last modified by SergeyBiryukov)

Previously:

Continuation of ongoing work to add and/or improve the PHPUnit tests @covers annotations for more accurate coverage reporting.

Change History (14)

#1 @hellofromTonya
4 years ago

  • Focuses coding-standards added

#2 @SergeyBiryukov
4 years ago

  • Description modified (diff)

#3 @SergeyBiryukov
4 years ago

In 54710:

Tests: Move the tests for WP class methods to the wp directory.

This aims to bring some consistency to the location of the tests for this class.

Includes adding the missing @covers tags.

Follow-up to [36177], [51622], [54250].

Props pbearne, SergeyBiryukov.
See #56793, #56782.

#4 @SergeyBiryukov
4 years ago

  • Summary PHPUnit tests: Add/improvement @covers annotations for WP 6.2PHPUnit tests: Add/improve @covers annotations for WP 6.2

#5 @SergeyBiryukov
4 years ago

In 54711:

Tests: Move dbDelta() tests to the db directory.

This aims to bring some consistency with other database-related tests.

Includes adding a missing @covers tag to the class DocBlock.

Follow-up to [30345], [32108], [32770], [51798].

Props pbearne, SergeyBiryukov.
See #56793, #56782.

#6 @SergeyBiryukov
4 years ago

In 54716:

Tests: Move the tests for pluggable function signatures to the pluggable directory.

This aims to bring some consistency to the location of pluggable function tests.

Includes:

  • Renaming the test class to better reflect the intention of the tests.
  • Adding a @coversNothing tag to the class DocBlock.

Follow-up to [34126], [53478], [54702].

Props pbearne, SergeyBiryukov.
See #56793, #56782.

This ticket was mentioned in PR #1255 on WordPress/wordpress-develop by @pbearne.


4 years ago
#7

  • Keywords has-unit-tests added

the ongoing covers ticket
I am still rechecking all the files so expect up[date to the pull request

Trac:
https://core.trac.wordpress.org/ticket/56782
https://core.trac.wordpress.org/ticket/39265

This ticket was mentioned in Slack in #core by sergey. View the logs.


4 years ago

#9 @hellofromTonya
4 years ago

  • Status assignedreviewing

There are new commits in the PR that are ready for review and commit. I'll be working on these during the remainder of the 6.2 cycle.

Triage folks:
This Trac ticket is for tests only. Please leave it in the 6.2 milestone. Thanks :)

This ticket was mentioned in Slack in #core by costdev. View the logs.


4 years ago

This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.


4 years ago

#12 @hellofromTonya
4 years ago

  • Resolutionfixed
  • Status reviewingclosed

Sadly other things took my attention from this. Closing this ticket as fixed for the 6.2 cycle. Work will continue once 6.3-alpha opens.

#13 @hellofromTonya
3 years ago

#57958 is now open for this work to continue in the 6.3 cycle.

@spacedmonkey commented on PR #1255:


3 years ago
#14

@pbearne Can I recommend breaking this into smaller PR. Or at least classes should be in new PR. This PR is really hard to review and harder to commit / revert.

Note: See TracTickets for help on using tickets.