#56786 closed task (blessed) (fixed)
Replace branches 3.7 - 4.0 update notices
Reported by: | peterwilsoncc | Owned by: | peterwilsoncc |
---|---|---|---|
Milestone: | 6.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Security | Keywords: | has-patch |
Focuses: | ui-copy | Cc: |
Attachments (5)
Change History (32)
This ticket was mentioned in PR #3683 on WordPress/wordpress-develop by @peterwilsoncc.
2 years ago
#1
This ticket was mentioned in PR #3684 on WordPress/wordpress-develop by @peterwilsoncc.
2 years ago
#2
https://core.trac.wordpress.org/ticket/56786 targeting 3.8 branch.
This ticket was mentioned in PR #3685 on WordPress/wordpress-develop by @peterwilsoncc.
2 years ago
#3
https://core.trac.wordpress.org/ticket/56786 targeting 3.9 branch.
This ticket was mentioned in PR #3686 on WordPress/wordpress-develop by @peterwilsoncc.
2 years ago
#4
https://core.trac.wordpress.org/ticket/56786 targeting 4.0 branch.
#5
@
2 years ago
In the linked pull requests:
- Notification changes from the original patches
- Version bumps
- About page updates
For the about page, I've labeled the fixes as security releases. There are not any existing strings for "this is the final release of WordPress x.x" so the existing string labeling them as security fixes was chosen as a best fit.
@peterwilsoncc commented on PR #3683:
2 years ago
#6
Thanks @audrasjb, I've addressed this in each of the pull requests relating to this ticket.
Note: based on a quick search this is a new string (it's not even in trunk). My understanding is that this shouldn't be too big of a problem, but it would be a good idea to get it in to core.
@audrasjb commented on PR #3683:
2 years ago
#7
Thanks!
Yes, you're right, the string doesn't exist in core for now.
I see you opened ticket 57216 for this, I'll send a PR this morning :)
This ticket was mentioned in PR #3695 on WordPress/wordpress-develop by @peterwilsoncc.
2 years ago
#8
https://core.trac.wordpress.org/ticket/56786 version and about page bump targeting 3.7 branch
This ticket was mentioned in PR #3696 on WordPress/wordpress-develop by @peterwilsoncc.
2 years ago
#9
https://core.trac.wordpress.org/ticket/56786 version and about page bump targeting 3.8 branch
This ticket was mentioned in PR #3697 on WordPress/wordpress-develop by @peterwilsoncc.
2 years ago
#10
https://core.trac.wordpress.org/ticket/56786 version and about page bump targeting 3.9 branch
This ticket was mentioned in PR #3698 on WordPress/wordpress-develop by @peterwilsoncc.
2 years ago
#11
https://core.trac.wordpress.org/ticket/56786 version and about page bump targeting 4.0 branch
This ticket was mentioned in Slack in #core-committers by peterwilsoncc. View the logs.
2 years ago
#13
@
2 years ago
- Milestone changed from Awaiting Review to 6.2
I've split the linked pull requests up in to two for each release: one to update the nag, the other for the version bump and about page update.
The new PRs contain code that @audrasjb approved earlier when they were bundled with the update nag notices.
wp-eol-scripts.zip contains the scripts I'll be running on the day.
#14
@
2 years ago
Ok, it looks great to me, I approved the split PRs.
By the way, not sure the ticket milestone should be 6.2 🤔
Maybe rather WordPress.org
? It doesn't make much more sense, but with this, it won't be attached to a 2023 release 🤷♂️
https://core.trac.wordpress.org/ticket/56786 targeting 3.7 branch.