Opened 2 years ago
Closed 19 months ago
#56790 closed task (blessed) (fixed)
PHP 8.x: various compatibility fixes for WordPress 6.2
Reported by: | SergeyBiryukov | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 6.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | php8 php81 php82 has-patch has-unit-tests |
Focuses: | coding-standards | Cc: |
Description
Previously:
This ticket will be used as an "epic", allowing a variety of small patches each fixing a specific failure to be added to and committed against this ticket.
For patches addressing all instances of failures related to one specific PHP version (such as PHP 8.0, 8.1, or 8.2) change across the codebase, separate tickets should still be opened.
For an example of issues/patches with separate tickets, see:
- #53299 PHP 8.1: Update
is_serialized
function to accept Enums - #53465 PHP 8.1.: the default value of the flags parameter for
htmlentities()
et all needs to be explicitly set
When opening a separate ticket, please tag it with the appropriate PHP version keyword so that these tickets can be easily found:
- PHP 8.2: keyword is
php82
with its report https://core.trac.wordpress.org/query?keywords=~php82 - PHP 8.1: keyword is
php81
with its report https://core.trac.wordpress.org/query?keywords=~php81 - PHP 8.0: keyword is
php8
with its report https://core.trac.wordpress.org/query?keywords=~php8
Change History (7)
This ticket was mentioned in PR #3777 on WordPress/wordpress-develop by @bjorsch.
22 months ago
#1
- Keywords has-patch has-unit-tests added
@SergeyBiryukov commented on PR #3777:
21 months ago
#4
Thanks for the PR! Merged in r55105.
The IXR_Message class declares a property
_currentTag
, which is never assigned or used. It does assign tocurrentTag
, which outside of that one assignment is never used either. A search on wpdirectory didn't turn up anything using either property (but lots of results for other classes having a property of the same name).Since there are various other underscore-prefixed properties declared on the class, including one named
_currentTagContents
which is used in several places, it seems likely the declared property is correct and the assignment is a typo.Trac ticket: https://core.trac.wordpress.org/ticket/56790