Opened 2 years ago
Closed 20 months ago
#56792 closed task (blessed) (fixed)
Docblock improvements for 6.2
Reported by: | desrosj | Owned by: | |
---|---|---|---|
Milestone: | 6.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | has-patch has-unit-tests |
Focuses: | docs | Cc: |
Change History (108)
This ticket was mentioned in PR #3449 on WordPress/wordpress-develop by @kebbet.
2 years ago
#2
- Keywords has-patch added
#3
follow-up:
↓ 8
@
2 years ago
There is no consensus on how to use behaviour
and behavior
in Core atm. Is this something that should be adressed/fixed?
This ticket was mentioned in PR #3450 on WordPress/wordpress-develop by @kebbet.
2 years ago
#4
#6
@
2 years ago
@kebbet we have a lot more "Behavior" occurrences than "Behaviour", so I'd say the current main consensus is "Behavior".
This ticket was mentioned in PR #3452 on WordPress/wordpress-develop by @kebbet.
2 years ago
#7
- Keywords has-unit-tests added
#8
in reply to:
↑ 3
@
2 years ago
Replying to kebbet:
There is no consensus on how to use
behaviour
andbehavior
in Core atm. Is this something that should be adressed/fixed?
Per the spelling guidelines, American English should be preferred, so I think we should standardize on behavior
.
#9
@
2 years ago
Thanks for making it clear @SergeyBiryukov!
I've added a PR with suggestions in PHP-files. I left out what i thought was included packages from others.
I've not touched CSS or JS files yet.
#11
follow-up:
↓ 13
@
2 years ago
@kebbet could you open a new ticket for this?
I've taken a brief look, and seems there are a few other occurrences of -ise
vs. -ize
and -or
vs. -our
that we should correct all at once.
For example, I see a couple of colour
where it should be color
, one occurrence of organise
(American English is organize
). Would be good to take a full pass for any. I used this page as a reference.
This could loosely be categorized as coding standards, but I think it deserves it's own ticket to for discussion and easier reference later on.
@audrasjb commented on PR #3449:
2 years ago
#12
committed in https://core.trac.wordpress.org/changeset/54505
@audrasjb commented on PR #3452:
2 years ago
#20
Committed in https://core.trac.wordpress.org/changeset/54663
#23
@
2 years ago
Reported on DevHub by @aleksganev, about wp_dropdown_users()
.
In the “Parameters” section, in the description of “option_none_value”, the variable “$show_option_non” is misspelled and should be “$show_option_none”
The description in question:
“Value to use for $show_option_non when no users were found. Default -1.”
I'm going to commit a fix directly.
This ticket was mentioned in PR #3594 on WordPress/wordpress-develop by pkevan.
2 years ago
#31
The changes below are a follow on from previous work to improve docblocks information in code.
The PR contains a small number of changes from a list of missing values - each file has a single commit to allow for cherry-picking.
Trac ticket: https://core.trac.wordpress.org/ticket/56792
2 years ago
#33
Thanks for the review and feedback @costdev - i've committed the fixes and also picked up some more inconsistencies in my searching 😄
This ticket was mentioned in PR #3627 on WordPress/wordpress-develop by @kebbet.
2 years ago
#38
Fix a typo in the PRESETS_METADATA constant description, in WP_Theme_JSON
@SergeyBiryukov commented on PR #3627:
2 years ago
#40
Thanks for the PR! Merged in r54853.
@audrasjb commented on PR #3594:
22 months ago
#68
I just noticed that we forgot this PR.
@pkevan could you please resolve the two small conflicts, so we can commit this PR?
Thanks!
This ticket was mentioned in PR #4047 on WordPress/wordpress-develop by @mukesh27.
21 months ago
#79
Trac ticket: https://core.trac.wordpress.org/ticket/56792
@mukesh27 commented on PR #4047:
21 months ago
#81
Thanks @costdev I can't find any other files in my search.
@mukesh27 commented on PR #4047:
21 months ago
#82
Thanks @costdev I can't find any other files in my search.
This ticket was mentioned in PR #4079 on WordPress/wordpress-develop by @kebbet.
21 months ago
#84
#85
@
21 months ago
PR 4079 sets the since version to 6.2.0 for all occurences of 6.1.2, beacause no 6.1.2 is released yet.
@audrasjb commented on PR #4079:
21 months ago
#86
Thanks for spotting this!
One related commit: https://core.trac.wordpress.org/changeset/55010
21 months ago
#87
Another commit -> https://core.trac.wordpress.org/changeset/55345
21 months ago
#89
And https://core.trac.wordpress.org/changeset/54973
Origin ticket was reopened for 6.1.2 https://core.trac.wordpress.org/ticket/57169#comment:5
@mukesh27 commented on PR #4079:
21 months ago
#90
Thanks @kebbet for PR.
One move related commit: https://core.trac.wordpress.org/changeset/54894
@mukesh27 commented on PR #4079:
21 months ago
#91
Thanks @kebbet for PR.
One move related commit: https://core.trac.wordpress.org/changeset/54894
@audrasjb commented on PR #4079:
21 months ago
#93
Committed in https://core.trac.wordpress.org/changeset/55349
@SergeyBiryukov commented on PR #4047:
21 months ago
#98
Thanks for the PR! Merged in r55393.
@SergeyBiryukov commented on PR #3594:
21 months ago
#100
Thanks for the PR! Merged in r55398 with some edits:
- Clarified the actual behavior where appropriate, e.g. "Defaults to the current post author" instead of just "Default false".
- Skipped a few instances of "Default empty array" when the array does in fact include some default values early in the function. Clarified those values where they were missing.
https://core.trac.wordpress.org/ticket/56792