Naming of filters in `class-wp-theme-json-resolver.php` (`theme_json_*`)

[kebbet]

With 6.1 we are introducing filters for theme.json, all named theme_json_* which results in filters like:

• theme_json_default
• theme_json_theme
• theme_json_blocks
• theme_json_user
• theme_json_theme

Are we ok with this?

To me, the naming is a bit odd, espcially theme_json_theme. Could better names for the filter be used?

[desrosj]

Thanks @kebbet! Moving to 6.1 for consideration. I agree, it seems a bit odd. But also not sure of a better suggestion.

[mukesh27]

+1 We are using wp_ prefix for the new filters.

[kebbet]

Plus theme_json_get_style_nodes in wp-includes/class-wp-theme-json.php and wp-includes/script-loader.php which is about to be introduced in 6.1 aswell.

Adding _data to filter names.
https://core.trac.wordpress.org/ticket/56796

[kebbet]

The linked PR leaves out theme_json_get_style_nodes from any changes.

Should we consider putting data in the middle, e.g. theme_json_data_default, etc. to closer match WP_Theme_JSON_Data?

Not sure about adding the wp_ prefix, but seems to make sense here too? theme_json_get_style_nodes would then also need the prefix.

Test failures are unrelated to this PR and are currently present in trunk.

[hellofromTonya]

There's consensus to use the wp_theme_json_data_{$context} naming structure. ​PR 3443 has been approved by 2 committers. It's ready for commit.

[hellofromTonya]

In 54501:

Editor: Rename new theme_json_{$context} filters.

The newly introduced filters are renamed to use the wp_theme_json_data{$context} structure:

• theme_json_default renamed to wp_theme_json_data_default
• theme_json_theme renamed to wp_theme_json_data_theme
• theme_json_blocks renamed to wp_theme_json_data_blocks
• theme_json_user renamed to wp_theme_json_data_user

The following new filter gets the wp_ prefix added:

• theme_json_get_style_nodes renamed to wp_theme_json_get_style_nodes

Follow-up to [56467], [54183], [54118].

Props kebbet, desrosj, mukesh27, ocean90, sergeybiryukov, davidbaumwald, hellofromTonya.
Fixes #56796.

Committed via changeset https://core.trac.wordpress.org/changeset/54501. Thank you everyone for your contributions 🎉

This PR needs a few follow-ups:

• ​x [The devnote for 6.1] (it had already been published when this PR was proposed). I've gone ahead and update it.
• [ ] The documentation for this in the handbook.
• [ ] The same code in Gutenberg.

I've prepared ​https://github.com/WordPress/gutenberg/pull/44940 to address the last two items. Would anyone be available for review?

[SergeyBiryukov]

In 54631:

Tests: Correct the wp_theme_json_data_default filter name in assertion messages.

The theme_json_default filter was previously renamed to wp_theme_json_data_default.

This commit updates the messages in WP_Theme_JSON_Resolver tests to match the new name.

Follow-up to [54501], [54630].

See #56796, #56835.