#56797 closed defect (bug) (fixed)
Add unit tests for block registration with RTL stylesheets
| Reported by: | SergeyBiryukov | Owned by: | SergeyBiryukov |
|---|---|---|---|
| Priority: | normal | Milestone: | 6.2 |
| Component: | Editor | Version: | |
| Severity: | normal | Keywords: | has-unit-tests dev-feedback has-patch |
| Cc: | Focuses: | css, rtl |
Description (last modified by )
Attachments (1)
Change History (15)
#2
@
4 years ago
- Summary Add unit tests for block registration tests with RTL stylesheets → Add unit tests for block registration with RTL stylesheets
This ticket was mentioned in Slack in #core by costdev. View the logs.
4 years ago
This ticket was mentioned in Slack in #core by costdev. View the logs.
4 years ago
This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.
4 years ago
This ticket was mentioned in PR #4150 on WordPress/wordpress-develop by @costdev.
4 years ago
#8
- Keywords has-patch added
This adds a PHPUnit test for register_block_style_handle() to confirm that RTL stylesheets for blocks are correctly loaded when an RTL locale is set.
Refreshes the previous patch.
Trac ticket: https://core.trac.wordpress.org/ticket/56797
#9
@
4 years ago
@SergeyBiryukov I've submitted PR 4150 which refreshes 56797.patch to improve the docblock, to reset the text direction before the assertions, and to add $message parameters to the assertions.
I ran a coverage report, and can confirm that the test covers the related lines - Screenshot.
This ticket was mentioned in Slack in #core by costdev. View the logs.
4 years ago
This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.
4 years ago
#12
@
4 years ago
This ticket was discussed during the bug scrub. @SergeyBiryukov, do you have time to take a look at PR 4150 before RC1 on Thursday 9th March?
Additional props: @mukesh27
@SergeyBiryukov commented on PR #4150:
4 years ago
#14
Thanks for the PR! Merged in r55486.
![(please configure the [header_logo] section in trac.ini)](/chrome/site/your_project_logo.png)
@SergeyBiryukov how's the above patch to cover the RTL-related code?