Changes between Version 1 and Version 2 of Ticket #56800, comment 5
- Timestamp:
- 03/03/2023 03:40:02 AM (20 months ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #56800, comment 5
v1 v2 7 7 ------ 8 8 9 Note that there are 462 uses of `$this->assertEquals()` remaining in the test suite. Many of these are testing objects, and are therefore fine. However, I think we should pursue the intention to add two new assertion s in 6.3:9 Note that there are 462 uses of `$this->assertEquals()` remaining in the test suite. Many of these are testing objects, and are therefore fine. However, I think we should pursue the intention to add two new assertion conventions in 6.3: 10 10 11 - `assertSimilarObject()` - A wrapper for `assertIsObject()` and `assertEquals()` when comparing objects.12 - `assertArrayEquals WithObject()` - A wrapper for `assertIsArray()` and `assertEquals()`when comparing arrays containing at least one object.11 - `assertSimilarObject()` - A new assertion that acts as a wrapper for `assertIsObject()` and `assertEquals()` when comparing objects. 12 - `assertArrayEquals()` - An existing assertion for use when comparing arrays containing at least one object. 13 13 14 14 Why? … … 16 16 17 17 When? 18 I can submit a PR for the se assertions as soon as we branch for 6.3. There was support for thesein previous cycles, but we never got around to it.18 I can submit a PR for the new `assertSimilarObject()` assertion as soon as we branch for 6.3. There was support for using these assertions in previous cycles, but we never got around to it. 19 19 20 20 -----