#56811 closed enhancement (fixed)
Improved spelling, align with American English
Reported by: | kebbet | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 6.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | General | Keywords: | |
Focuses: | docs, coding-standards | Cc: |
Description
Per the spelling guidelines, American English should be preferred in Core.
There are a few other occurrences of -ise
vs. -ize
and -or
vs. -our
that we should correct all at once.
For example:
- colour vs. color
- organise vs. organize
- behaviour vs. behavior
This page could be a reference for spelling.
This ticket is a break out #56792
Change History (35)
This ticket was mentioned in PR #3452 on WordPress/wordpress-develop by @kebbet.
2 years ago
#1
- Keywords has-patch has-unit-tests added; needs-patch removed
This ticket was mentioned in PR #3455 on WordPress/wordpress-develop by @costdev.
2 years ago
#2
This replaces two instances of "cancelled" with "canceled", per the Spelling Guidelines.
Trac ticket: https://core.trac.wordpress.org/ticket/56811
This ticket was mentioned in PR #3503 on WordPress/wordpress-develop by @kebbet.
2 years ago
#3
#4
@
2 years ago
- Owner set to audrasjb
- Status changed from new to reviewing
The "behaviour/behavior" PR looks good to me.
Self assigning for commit
.
@audrasjb commented on PR #3452:
2 years ago
#6
Committed in https://core.trac.wordpress.org/changeset/54663
@audrasjb commented on PR #3455:
2 years ago
#8
Committed in https://core.trac.wordpress.org/changeset/54664
This ticket was mentioned in PR #3592 on WordPress/wordpress-develop by @ironprogrammer.
2 years ago
#9
Update use of "-ise" suffix to American English "-ize". Checked for (normal|standard|initial|color|colour)ise
.
Trac ticket: https://core.trac.wordpress.org/ticket/56811
This ticket was mentioned in PR #3628 on WordPress/wordpress-develop by @kebbet.
2 years ago
#10
https://core.trac.wordpress.org/ticket/56811
- [Spelling: behaviuor in postbox.js]
- [Initialise and authorisation]
@audrasjb commented on PR #3628:
2 years ago
#14
Committed in https://core.trac.wordpress.org/changeset/55044
@audrasjb commented on PR #3503:
2 years ago
#16
Committed in https://core.trac.wordpress.org/changeset/55045
#17
@
2 years ago
- Keywords has-patch has-unit-tests removed
Hello there,
All the PR have been committed now. Let's keep this ticket open for other occurrences.
#18
@
2 years ago
- Keywords needs-patch added
Just finding some more: unsanitised
, parenthesised
and specialised
. A PR is needed for them.
This ticket was mentioned in PR #3834 on WordPress/wordpress-develop by @kebbet.
2 years ago
#19
- Keywords has-patch added; needs-patch removed
https://core.trac.wordpress.org/ticket/56811
This changeset updates the use of "-ise" suffix to American English "-ize".
#20
@
2 years ago
I'm worried about [55045] being an unnecessary back-compat break, the function will no longer work for developers using it in their own admin CSS files.
Is it possible to retain or at least alias it?
#21
@
2 years ago
Hmm, that's a good point @peterwilsoncc, I found 14 plugins using this function using wpdirectory.
While they shouldn't break since they are just reusing the function for custom admin themes, I think we should not take the risk.
Also, this is a very minor change, I'm not sure we should take the risk for such a tiny improvement.
I'll revert this change, that's probably the most relevant option for now.
Thanks for chiming in 👍
#22
@
2 years ago
Thanks @audrasjb -- while you are reverting are you able to add a comment explaining it's using British English to maintain backward compatibility for developers using the function in their scss?
@mukesh27 commented on PR #3834:
2 years ago
#24
@kebbet Thanks for PR. Looks good to me and approved for merge!
This ticket was mentioned in PR #3840 on WordPress/wordpress-develop by @kebbet.
2 years ago
#25
https://core.trac.wordpress.org/ticket/56811
Revert the name change of the admin scss-function. Keep function url-friendly-colour
to maintain backward compatibility.
#26
@
2 years ago
@peterwilsoncc Thanks for raising your concerns!
@audrasjb: PR3840 addresses the concern and adds a comment on British English.
@audrasjb commented on PR #3840:
2 years ago
#28
Committed in https://core.trac.wordpress.org/changeset/55048
@audrasjb commented on PR #3834:
2 years ago
#30
Committed in https://core.trac.wordpress.org/changeset/55051
#32
@
23 months ago
@audrasjb @kebbet Looks like all patches have been merged. Is there anything left for this ticket, or is it ready to close as fixed
?
#33
@
23 months ago
Thanks for heads up @costdev!
I suggest closing this as fixed. Any new non US-english findings can be adressed in one or multiple follow-up tickets.
I know from my investigations that there is more British English spelling in core, but it's in the included libraries.
https://core.trac.wordpress.org/ticket/56811