Make WordPress Core

Opened 18 months ago

Closed 15 months ago

Last modified 11 months ago

#56811 closed enhancement (fixed)

Improved spelling, align with American English

Reported by: kebbet's profile kebbet Owned by: audrasjb's profile audrasjb
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: General Keywords:
Focuses: docs, coding-standards Cc:

Description

Per the spelling guidelines, American English should be preferred in Core.

There are a few other occurrences of -ise vs. -ize and -or vs. -our that we should correct all at once.

For example:

  • colour vs. color
  • organise vs. organize
  • behaviour vs. behavior

This page could be a reference for spelling.

This ticket is a break out #56792

Change History (35)

This ticket was mentioned in PR #3452 on WordPress/wordpress-develop by @kebbet.


18 months ago
#1

  • Keywords has-patch has-unit-tests added; needs-patch removed

This ticket was mentioned in PR #3455 on WordPress/wordpress-develop by @costdev.


18 months ago
#2

This replaces two instances of "cancelled" with "canceled", per the Spelling Guidelines.

Trac ticket: https://core.trac.wordpress.org/ticket/56811

#4 @audrasjb
18 months ago

  • Owner set to audrasjb
  • Status changed from new to reviewing

The "behaviour/behavior" PR looks good to me.
Self assigning for commit.

#5 @audrasjb
18 months ago

In 54663:

Docs: Align spelling with American English.

This changeset replaces "behaviour" with "behavior" in various docblocks.

Props kebbet, jrf.
See #56811, #56792.

#7 @audrasjb
18 months ago

In 54664:

Docs: Align spelling with American English.

This changeset replaces "cancelled" with "canceled" in various docblocks, per the Spelling Guidelines.

Props costdev.
See #56811, #56792.

This ticket was mentioned in PR #3592 on WordPress/wordpress-develop by @ironprogrammer.


18 months ago
#9

Update use of "-ise" suffix to American English "-ize". Checked for (normal|standard|initial|color|colour)ise.

Trac ticket: https://core.trac.wordpress.org/ticket/56811

This ticket was mentioned in PR #3628 on WordPress/wordpress-develop by @kebbet.


17 months ago
#10

https://core.trac.wordpress.org/ticket/56811

  • [Spelling: behaviuor in postbox.js]
  • [Initialise and authorisation]

#11 @SergeyBiryukov
17 months ago

  • Milestone changed from Awaiting Review to 6.2

#12 @audrasjb
15 months ago

In 55043:

Docs: Align spelling with American English.

This changeset updates the use of "-ise" suffix to American English "-ize" in docblocks.

Follow-up to [54663], [54664].

Props ironprogrammer, costdev.
See #56811, #56792.

#13 @audrasjb
15 months ago

In 55044:

Docs: Align spelling with American English.

This changeset updates the use of "-ise" suffix to American English "-ize" and replaces "behaviour" with "behavior" in various docblocks.

Follow-up to [54663], [54664], [55043].

Props kebbet.
See #56811, #56792.

#15 @audrasjb
15 months ago

In 55045:

General: Align spelling with American English.

This changeset renames url-friendly-colour to url-friendly-color in _admin.scss.

Follow-up to [54663], [54664], [55043], [55044].

Props kebbet.
See #56811.

#17 @audrasjb
15 months ago

  • Keywords has-patch has-unit-tests removed

Hello there,

All the PR have been committed now. Let's keep this ticket open for other occurrences.

#18 @kebbet
15 months ago

  • Keywords needs-patch added

Just finding some more: unsanitised, parenthesised and specialised. A PR is needed for them.

Last edited 15 months ago by kebbet (previous) (diff)

This ticket was mentioned in PR #3834 on WordPress/wordpress-develop by @kebbet.


15 months ago
#19

  • Keywords has-patch added; needs-patch removed

https://core.trac.wordpress.org/ticket/56811

This changeset updates the use of "-ise" suffix to American English "-ize".

#20 @peterwilsoncc
15 months ago

I'm worried about [55045] being an unnecessary back-compat break, the function will no longer work for developers using it in their own admin CSS files.

Is it possible to retain or at least alias it?

#21 @audrasjb
15 months ago

Hmm, that's a good point @peterwilsoncc, I found 14 plugins using this function using wpdirectory.
While they shouldn't break since they are just reusing the function for custom admin themes, I think we should not take the risk.
Also, this is a very minor change, I'm not sure we should take the risk for such a tiny improvement.

I'll revert this change, that's probably the most relevant option for now.
Thanks for chiming in 👍

#22 @peterwilsoncc
15 months ago

Thanks @audrasjb -- while you are reverting are you able to add a comment explaining it's using British English to maintain backward compatibility for developers using the function in their scss?

#23 @audrasjb
15 months ago

Sure, let's keep some kind of history 🙂

@mukesh27 commented on PR #3834:


15 months ago
#24

@kebbet Thanks for PR. Looks good to me and approved for merge!

This ticket was mentioned in PR #3840 on WordPress/wordpress-develop by @kebbet.


15 months ago
#25

https://core.trac.wordpress.org/ticket/56811

Revert the name change of the admin scss-function. Keep function url-friendly-colour to maintain backward compatibility.

#26 @kebbet
15 months ago

@peterwilsoncc Thanks for raising your concerns!

@audrasjb: PR3840 addresses the concern and adds a comment on British English.

#27 @audrasjb
15 months ago

In 55048:

General: revert [55045].

This changeset reverts [55045] to maintain backward compatibility for developers using the function in their SCSS.

Follow-up to [55045].

Unprops audrasjb.
Props peterwilsoncc, kebbet.
See #56811.

#29 @audrasjb
15 months ago

In 55051:

Docs: Align spelling with American English.

This changeset updates the use of "-ise" suffix to American English "-ize" in various files.

Follow-up to [54663], [54664], [55043], [55044].

Props kebbet, mukesh27.
See #56811, #56792.

#31 @kebbet
15 months ago

  • Keywords has-patch removed

#32 @costdev
15 months ago

@audrasjb @kebbet Looks like all patches have been merged. Is there anything left for this ticket, or is it ready to close as fixed?

#33 @kebbet
15 months ago

Thanks for heads up @costdev!

I suggest closing this as fixed. Any new non US-english findings can be adressed in one or multiple follow-up tickets.

I know from my investigations that there is more British English spelling in core, but it's in the included libraries.

#34 @audrasjb
15 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

Closing this as fixed, thanks everyone.

#35 @SergeyBiryukov
11 months ago

#58315 was marked as a duplicate.

Note: See TracTickets for help on using tickets.