#56818 closed defect (bug) (fixed)
Padding within table cells ignored
Reported by: | vtad | Owned by: | desrosj |
---|---|---|---|
Milestone: | 6.1.1 | Priority: | normal |
Severity: | normal | Version: | 6.1 |
Component: | Editor | Keywords: | close |
Focuses: | Cc: |
Description
I defined the padding (10 px) for the table-block. It shows correctly in the Editor, but it is ignored when displaying at the front end of twenty twenty three
Change History (28)
#1
@
2 years ago
- Component changed from Themes to Bundled Theme
- Milestone changed from Awaiting Review to 6.1
- Summary changed from Twenty twenty three 6.1 RC1 ignores padding to Twenty Twenty-Three: 6.1 RC1 ignores padding
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
2 years ago
#3
@
2 years ago
Thanks for reporting, @vtad!
Could you please provide the block markup that you were using? You can copy this by clicking on the three-dot menu for the table block, and then clicking 'Copy block'.
I am able to see the padding I've set both in the editor and on the front end, like this:
However, I'm not seeing the cell borders. It looks like these are only set within the editor, and not on the front end. I've opened an upstream issue for this: https://github.com/WordPress/gutenberg/issues/45065
This ticket was mentioned in Slack in #core by chaion07. View the logs.
2 years ago
#6
@
2 years ago
I think I've tracked this padding issue down to the changes in https://github.com/WordPress/gutenberg/pull/44640, where we removed the theme.css from loading in the editor if the theme does not opt into block styles. I believe this is the correct behaviour for now.
To improve this specifically for the table block, perhaps we could always include that default padding value on both the front end and in the editor since it's not currently editable via Global Styles? I've tried this in a PR here: https://github.com/WordPress/gutenberg/pull/45069
#7
@
2 years ago
- Summary changed from Twenty Twenty-Three: 6.1 RC1 ignores padding to Twenty Twenty-Three: 6.1 RC1 ignores padding within the celss
The table block
<!-- wp:table {"style":{"border":{"width":"1px"},"spacing":{"padding":{"top":"10px","right":"10px","bottom":"10px","left":"10px"}}},"borderColor":"cyan-bluish-gray","className":"is-style-stripes"} --> <figure class="wp-block-table is-style-stripes" style="padding-top:10px;padding-right:10px;padding-bottom:10px;padding-left:10px"><table class="has-border-color has-cyan-bluish-gray-border-color" style="border-width:1px"><tbody><tr><td>1</td><td>2</td><td>3</td></tr><tr><td>DAX – Tageschart Ichimoku-Analyse</td><td>Georg </td><td>13. Okt 2022</td></tr><tr><td>DAX – ein irritierendes Interview und ein intakter Abwärtstrend</td><td>Karin Roller</td><td>15. Sep 2022</td></tr><tr><td>4</td><td>5</td><td>6</td></tr></tbody></table></figure> <!-- /wp:table -->
Front Page : https://proto.vtad.de/
#8
@
2 years ago
- Summary changed from Twenty Twenty-Three: 6.1 RC1 ignores padding within the celss to Twenty Twenty-Three: 6.1 RC1 ignores padding within the cells
This ticket was mentioned in Slack in #core by audrasjb. View the logs.
2 years ago
#10
@
2 years ago
This issue was reported upstream on Gutenberg repo, but since it’s not milestoned, I don’t think it’s going to be fixed in time for 6.1.
Let’s give it one more day, then punt it to the next minor.
#11
@
2 years ago
- Keywords reporter-feedback removed
- Milestone changed from 6.1 to 6.1.1
There is a PR upstream attempting to improve this. While this is not ideal, it's not a blocker or serious issue for 6.1 to be released.
I'm punting to 6.1.1 so we can follow up on it in the next minor release.
#13
@
2 years ago
This upstream PR should address this: https://github.com/WordPress/gutenberg/pull/45069
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
2 years ago
#16
@
2 years ago
@mikachan can you check to see whether the Add citation text is aligned at the center or does it move to the left?
#17
@
2 years ago
Hi @nithins53, do you mean the caption text in the Table block? It looks like this is centered for me in the editor, and it is displayed on the left on the front end:
Editor | Front end | |
---|---|---|
It's also a different font style. These should really be the same between the editor and front end. I'm happy to take a look at this, unless you'd like to?
#18
@
2 years ago
@mikachan Yes, I was referring to the Add Caption text. Upon testing, I found it to be aligned to the left. It would be nice if you could take a look into it.
#19
@
2 years ago
- Keywords close added
The noted upstream PR has been merged on GitHub and marked for merging into SVN.
Marking as close
since this will be resolved when that happens.
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
2 years ago
#23
@
2 years ago
- Summary changed from Twenty Twenty-Three: 6.1 RC1 ignores padding within the cells to Padding within table cells ignored
Thanks for this report @vtad, and welcome to Trac!
I'm moving this to the milestone to be investigated.