Make WordPress Core

Opened 20 months ago

Last modified 20 months ago

#56821 new enhancement

meta_query late row lookup for performance improvement

Reported by: brmoore252's profile brmoore252 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version:
Component: Options, Meta APIs Keywords: needs-patch needs-testing
Focuses: performance Cc:

Description

Is it possible to do a late row lookup for meta_query to make large postmeta sets run much faster?

In some benchmarking I've done with load testing, queries that would take 8s to load with the current meta_query ended up loading in 500ms after implementing late row lookup.

My suggestion would be to modify the get_posts function in the WP_Query class to have a flag pass through to use late lookup, like passing through "meta_late_lookup"=>true:

<?php
if ( ! empty( $this->meta_query->queries ) ) {
        $clauses = $this->meta_query->get_sql( 'post', $wpdb->posts, 'ID', $this );
        if(isset($q['meta_query_late_lookup']) && $q['meta_query_late_lookup']){
                // perform a late lookup instead of a join
                $clauses['where'] = ' AND ID in (SELECT post_id FROM '.$wpdb->postmeta.' WHERE 1=1 '.$clauses['where'].')';
        } else {
                $join   .= $clauses['join'];
        }
        $where  .= $clauses['where'];
}

At the moment, this can be accomplished with a filter like so:

<?php
add_filter('get_meta_sql', 'meta_sql_late_row_lookup', NULL, 6);
function meta_sql_late_row_lookup($sql, $queries, $type, $table, $column, $context){
        $meta_table = _get_meta_table( $type );
        $sql = array('where'=>' AND ID in (SELECT post_id FROM '.$meta_table.' WHERE 1=1 '.$sql['where'].')');
        return $sql;
}

Change History (1)

#1 @johnbillion
20 months ago

  • Component changed from Posts, Post Types to Options, Meta APIs
  • Focuses performance added
  • Keywords needs-patch needs-testing added; changes-requested removed
Note: See TracTickets for help on using tickets.