WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 23 months ago

Last modified 23 months ago

#56829 closed defect (bug) (reported-upstream)

use 'esc_url' for 'get_author_posts_url' where appropriate in 'src/wp-includes/blocks/avatar.php'

Reported by: hztyfoon's profile hztyfoon Owned by:
Milestone: Priority: normal
Severity: normal Version: 6.0
Component: Editor Keywords:
Focuses: coding-standards Cc:

Description

In 'src/wp-includes/blocks/avatar.php' file line number 103 the 'get_author_posts_url' method should be escaped.

related ticket: #56674 / [54344]

Change History (9)

This ticket was mentioned in ​PR #3477 on ​WordPress/wordpress-develop by ​@rudlinkon.
2 years ago #1

  • Keywords has-patch added

Trac ticket: https://core.trac.wordpress.org/ticket/56829

#2 @robinwpdeveloper
2 years ago

Excited to share that we have arranged a local meetup (Dhaka WordPress Meetup) on How to Get Started with Core Contribution and created this ticket with PR in a live session 😊🎉 🇧🇩

#3 @SergeyBiryukov
2 years ago

  • Component changed from General to Editor

Hi there, welcome back to WordPress Trac! Thanks for the ticket and the PR.

Please note that files in wp-includes/blocks/ should not be patched directly here in this repository. Instead, it would need to be fixed in the ​block-library package upstream, specifically in the ​avatar block, and then it will be merged into core as part of package updates.

Could you create an issue or PR at ​https://github.com/WordPress/gutenberg? Thanks!

This ticket was mentioned in ​Slack in #core-test by ironprogrammer. ​View the logs.
2 years ago

This ticket was mentioned in ​Slack in #core by desrosj. ​View the logs.
23 months ago

This ticket was mentioned in ​Slack in #core by bernhardreiter. ​View the logs.
23 months ago

#7 @desrosj
23 months ago

  • Keywords reporter-feedback close added
  • Version changed from 6.1 to 6.0

Seems this was introduced in [53157] as part of 6.0.

@hztyfoon can you confirm you've opened a ticket to address upstream?

#8 @hztyfoon
23 months ago

  • Keywords has-patch reporter-feedback removed
  • Resolution set to reported-upstream
  • Status changed from new to closed

Sorry, was little busy & almost forgot about it.

Thanks @SergeyBiryukov for the tip.
Thanks @desrosj @robinwpdeveloper for the reminder.

I just reported upstream here: ​https://github.com/WordPress/gutenberg/issues/45426

#9 @desrosj
23 months ago

  • Keywords close removed
  • Milestone Awaiting Review deleted

No worries! Thanks for following up.

Note: See TracTickets for help on using tickets.