WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#56839 closed defect (bug) (fixed)

Document the $wp_query global in WP_Media_List_Table::display_rows()

Reported by: upadalavipul Owned by: SergeyBiryukov
Priority: normal Milestone: 6.2
Component: Media Version: 6.1
Severity: normal Keywords: has-patch
Cc: Focuses: docs, administration

Description

I am checking for all function commenting details for good documentation and well comment and in which I have found one file that needs improvement. please check the below details.

file path: wp-admin/includes/class-wp-media-list-table.php

function name: display_rows()

Attachments (1)

56839.patch​ (445 bytes ) - added by upadalavipul 4 years ago.

Download all attachments as: .zip

Change History (6)

@upadalavipul
4 years ago

This ticket was mentioned in ​PR #3495 on ​WordPress/wordpress-develop by ​@saumil1611.
4 years ago #1

  • Keywords has-patch added

Add param in doc
Ticket Ref: https://core.trac.wordpress.org/ticket/56839

#2 @SergeyBiryukov
4 years ago

  • Component General → Media
  • Focuses administration added
  • Owner set to SergeyBiryukov
  • Status new → accepted
  • Summary Class function details need to improvement in class-wp-media-list-table.php file. → Document the $wp_query global in WP_Media_List_Table::display_rows()

#3 @SergeyBiryukov
4 years ago

  • Milestone Awaiting Review → 6.2

#4 @SergeyBiryukov
4 years ago

  • Resolution → fixed
  • Status accepted → closed

In 54661:

Docs: Document the usage of $wp_query global in WP_Media_List_Table::display_rows().

Follow-up to [34127].

Props upadalavipul, saumil1611.
Fixes #56839.

​@SergeyBiryukov commented on ​PR #3495:
4 years ago #5

Thanks for the PR! Merged in r54661.

Note: See TracTickets for help on using tickets.