Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #56850, comment 8


Ignore:
Timestamp:
10/19/2022 11:02:40 PM (3 years ago)
Author:
SergeyBiryukov
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #56850, comment 8

    initial v1  
    1010Deprecated: trim(): Passing null to parameter #1 ($string) of type string is deprecated
    1111}}}
    12 * The `$credentials['user_login']` and `$credentials['user_password']` parameters are passed by reference to the `wp_authenticate` action, and this is where the are [https://www.php.net/manual/en/language.references.pass.php#124383 created as `null` if they don't exist].
     12* The `$credentials['user_login']` and `$credentials['user_password']` parameters are passed by reference to the `wp_authenticate` action, and this is where they are [https://www.php.net/manual/en/language.references.pass.php#124383 created as `null` if they don't exist].
    1313* Since the parameters are documented as strings in various places (`wp_authenticate` action, `secure_signon_cookie` filter, `wp_authenticate()` function, `authenticate` filter, etc.) is seems like a bug that they are created as `null` instead of an empty string. Documenting `null` as a possible value does not seem ideal, as it forces plugins to deal with the issue on their own instead of fixing it at the source.
    1414