WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#56866 closed defect (bug) (fixed)

Coding Standards: Use strict comparison in wp-admin/update-core.php

Reported by: rezakhan995 Owned by: SergeyBiryukov
Priority: normal Milestone: 6.2
Component: Upgrade/Install Version: 2.5
Severity: normal Keywords: has-patch
Cc: Focuses: coding-standards

Description

Updated comparison to strict comparison in conditions in wp-admin/update-core.php

Change History (9)

This ticket was mentioned in ​PR #3502 on ​WordPress/wordpress-develop by ​rezakhan995.
4 years ago #1

Updated comparison to strict comparison in conditions in wp-admin/update-core.php

Trac ticket:

#2 @kebbet
4 years ago

  • Version 6.1 → 4.5

Introduced in [36349] during 4.5

#3 @mukesh27
4 years ago

  • Component General → Upgrade/Install
  • Milestone Awaiting Review → 6.2

Hi there!

Thanks for the ticket and PR.

PR looks good to me and approved. Moving to 6.2

#4 @SergeyBiryukov
4 years ago

  • Owner set to SergeyBiryukov
  • Status new → accepted

Hi there, welcome to WordPress Trac! Thanks for the ticket.

[47808] aimed to address changes like this, but it looks like this instance was missed in that commit.

The PR looks good.

#5 @kebbet
4 years ago

I was wrong with the introducing changset, I can not find the correct changeset with the GitHub-repo, can trace it back to #24976/[25001], but that's not the real source. Which means version is incorrect.

Last edited 4 years ago by kebbet (previous) (diff)

#6 follow-up: @kebbet
4 years ago

  • Version 4.5 → 2.5

So, the source might be, [8595]. That means version 2.5.

#7 in reply to: ↑ 6 @SergeyBiryukov
4 years ago

Replying to kebbet:

So, the source might be, [8595]. That means version 2.5.

That looks correct :) [36349] is relevant too, it added the second part of the conditional.

Last edited 4 years ago by SergeyBiryukov (previous) (diff)

#8 @SergeyBiryukov
4 years ago

  • Resolution → fixed
  • Status accepted → closed

In 54654:

Coding Standards: Use strict comparison in wp-admin/update-core.php.

This updates a conditional in do_core_upgrade() to use strict comparison for error codes that are static strings.

Follow-up to [8595], [36349].

Props rezakhan995, kebbet, mukesh27, jrf, SergeyBiryukov.
Fixes #56866.

​@SergeyBiryukov commented on ​PR #3502:
4 years ago #9

Thanks for the PR! Merged in r54654.

Note: See TracTickets for help on using tickets.