WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#56868 closed enhancement (fixed)

Add test coverage for _truncate_post_slug

Reported by: xknown's profile xknown Owned by: hellofromtonya's profile hellofromTonya
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: Posts, Post Types Keywords: has-patch has-unit-tests commit
Focuses: Cc:

Description

[52457] should have some unit tests for _truncate_post_slug() to confirm that post slugs are properly truncated when they contain URL encoded characters.

Change History (10)

This ticket was mentioned in ​PR #3505 on ​WordPress/wordpress-develop by ​xknown.
2 years ago #1

  • Keywords has-patch has-unit-tests added

Trac ticket: https://core.trac.wordpress.org/ticket/56868

#2 @SergeyBiryukov
2 years ago

  • Milestone changed from Awaiting Review to 6.2

#3 @mukesh27
2 years ago

  • Keywords changes-requested added

@xknown left some review on PR.

This ticket was mentioned in ​Slack in #core by costdev. ​View the logs.
2 years ago

#5 @hellofromTonya
2 years ago

  • Owner set to hellofromTonya
  • Status changed from new to reviewing

Self-assigning ownership for code review and commit.

This ticket was mentioned in ​Slack in #core by mukeshpanchal27. ​View the logs.
2 years ago

#7 @mukesh27
2 years ago

  • Keywords changes-requested removed

#8 @mukesh27
2 years ago

  • Keywords commit added

This ticket was discussed in the recent bug scrub.

The PR got enough approval. Adding commit keyword for 6.2 consideration.

Props to @costdev

#9 @peterwilsoncc
2 years ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 55208:

Posts, Post Types: Add test coverage for _truncate_post_slug().

Props xknown, mukesh27, costdev, audrasjb.
Fixes #56868.
See #56793.

Note: See TracTickets for help on using tickets.