Make WordPress Core

Opened 14 months ago

Closed 11 months ago

Last modified 10 months ago

#56869 closed feature request (fixed)

Add "Style variations" theme tag

Reported by: poena's profile poena Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: Themes Keywords: has-patch commit has-unit-tests add-to-field-guide
Focuses: Cc:

Description

Add a new theme tag called "Style variations" to help users find themes with style variations, a block theme feature where the theme developer includes an alternative .json configuration file for block settings and styles.

  • Theme developers can add the tag 'style-variations' to the file header in style.css.
  • Users can sort themes with style variations using the theme filter on the theme selection screen.

Companion ticket to https://meta.trac.wordpress.org/ticket/6545.

Attachments (3)

56869.diff (571 bytes) - added by poena 14 months ago.
56869-2.diff (570 bytes) - added by poena 14 months ago.
56869-3.diff (599 bytes) - added by costdev 11 months ago.
Adjust capitalization for consistency with the other strings.

Download all attachments as: .zip

Change History (14)

@poena
14 months ago

#1 @SergeyBiryukov
14 months ago

  • Milestone changed from Awaiting Review to 6.2

#2 @mukesh27
14 months ago

  • Keywords has-patch needs-refresh added

@poena Small change can you align the arrow in the patch?

@poena
14 months ago

#3 @poena
13 months ago

  • Keywords needs-refresh removed

#4 @robinwpdeveloper
12 months ago

Do we need to do any testing for this?
If yes, @poena can you provide testing instructions? :)

This ticket was mentioned in Slack in #core by costdev. View the logs.


11 months ago

@costdev
11 months ago

Adjust capitalization for consistency with the other strings.

#6 @costdev
11 months ago

  • Keywords commit added

This ticket was discussed in the recent bug scrub. It was agreed that the Style variations string should have its capitalization adjusted to Style Variations for consistency with the other strings. I've added 56869-3.diff which does this.

Adding the commit keyword.

This ticket was mentioned in PR #3922 on WordPress/wordpress-develop by @costdev.


11 months ago
#7

  • Keywords has-unit-tests added

This PR refreshes patch: 41574.2.diff to:

  • Fix CS issues.
  • Update @since annotation and remove an empty line from the docblock.
  • Backward compatibility: Use single quotes for attribute values.
  • Remove an unnecessary array_map() for performance.
  • Addresses concerns about the image attributes and link attributes clashing.
    • Image attributes: Stays as $attr for backward compatibility (i.e. named parameters).
    • Link attributes: Is called $attributes and, once collapsed to a string, $link_attributes, for consistency with $link_text.
  • Add tests.

Trac ticket: https://core.trac.wordpress.org/ticket/56869

#8 @costdev
11 months ago

Mis-link of PR, sincere apologies. 56869-3.diff is still a valid patch for this ticket.

Last edited 11 months ago by costdev (previous) (diff)

#9 @SergeyBiryukov
11 months ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 55149:

Themes: Add "Style Variations" to the list of WordPress theme features.

Follow-up to [meta12372].

Props poena, mukesh27, costdev.
Fixes #56869. See #meta6545.

#11 @milana_cap
10 months ago

  • Keywords add-to-field-guide added
Note: See TracTickets for help on using tickets.