#56869 closed feature request (fixed)
Add "Style variations" theme tag
Reported by: | poena | Owned by: | SergeyBiryukov |
---|---|---|---|
Milestone: | 6.2 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Themes | Keywords: | has-patch commit has-unit-tests add-to-field-guide |
Focuses: | Cc: |
Description
Add a new theme tag called "Style variations" to help users find themes with style variations, a block theme feature where the theme developer includes an alternative .json configuration file for block settings and styles.
- Theme developers can add the tag 'style-variations' to the file header in style.css.
- Users can sort themes with style variations using the theme filter on the theme selection screen.
Companion ticket to https://meta.trac.wordpress.org/ticket/6545.
Attachments (3)
Change History (14)
#4
@
2 years ago
Do we need to do any testing for this?
If yes, @poena can you provide testing instructions? :)
This ticket was mentioned in Slack in #core by costdev. View the logs.
23 months ago
#6
@
23 months ago
- Keywords commit added
This ticket was discussed in the recent bug scrub. It was agreed that the Style variations
string should have its capitalization adjusted to Style Variations
for consistency with the other strings. I've added 56869-3.diff which does this.
Adding the commit
keyword.
This ticket was mentioned in PR #3922 on WordPress/wordpress-develop by @costdev.
23 months ago
#7
- Keywords has-unit-tests added
This PR refreshes patch: 41574.2.diff to:
- Fix CS issues.
- Update
@since
annotation and remove an empty line from the docblock. - Backward compatibility: Use single quotes for attribute values.
- Remove an unnecessary
array_map()
for performance. - Addresses concerns about the image attributes and link attributes clashing.
- Image attributes: Stays as
$attr
for backward compatibility (i.e. named parameters). - Link attributes: Is called
$attributes
and, once collapsed to a string,$link_attributes
, for consistency with$link_text
.
- Image attributes: Stays as
- Add tests.
Trac ticket: https://core.trac.wordpress.org/ticket/56869
#8
@
23 months ago
Mis-link of PR, sincere apologies. 56869-3.diff is still a valid patch for this ticket.
#9
@
23 months ago
- Owner set to SergeyBiryukov
- Resolution set to fixed
- Status changed from new to closed
In 55149:
@audrasjb commented on PR #3922:
22 months ago
#10
committed in https://core.trac.wordpress.org/changeset/55262
@poena Small change can you align the arrow in the patch?