WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 21 and Version 30 of Ticket #56876


Ignore:
Timestamp:
03/16/2023 12:34:02 PM (9 months ago)
Author:
hellofromTonya
Comment:

Updated the ticket's description to include the references to:

  • ​the livestream, where these changes were discussed and agreed to by @markjaquith, @jrf, and me.
  • #56034 - as this change is part of that work.

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #56876

    • Property Status changed from new to reviewing
    • Property Owner set to hellofromTonya
    • Property Milestone changed from 6.2 to 6.3
    • Property Keywords early commit added
    • Property Summary changed from Refactor magic methods in WP_List_Table, WP_User_Query, WP_Text_Diff_Renderer_Table and WP_Admin_Bar classes to Dynamic Properties: Fix magic methods in WP_List_Table, WP_User_Query, WP_Text_Diff_Renderer_Table and WP_Admin_Bar classes

  • Ticket #56876 – Description

    v21 v30  
    1 `WP_List_Table`, `WP_User_Query`, and `WP_Text_Diff_Renderer_Table` classes implement some magic methods.
     1`WP_List_Table`, `WP_User_Query`, and `WP_Text_Diff_Renderer_Table` classes implement an incomplete set of magic methods.
    22
    33But these magic methods need to be refactored to ensure that these classes are compatible with PHP 8.2 (the magic methods in these classes are only partially implemented, the missing/incomplete magic methods should be added/refactored).
    … …  
    88
    99Props to @jrf for identifying the issue 👏.
     10
     11References:
     12* These changes were [https://www.youtube.com/watch?v=vDZWepDQQVE&t=9362s discussed and agreed to in a livestream] by @jrf @ markjaquith and @hellofromTonya.
     13* The changes are part of #56034, which is the larger Dynamic Properties proposal and initiative.