WordPress.org

Make WordPress Core

Opened 6 years ago

Closed 3 months ago

#5689 closed enhancement (wontfix)

smilies should not wrap on line-break

Reported by: gpoul Owned by:
Milestone: Priority: low
Severity: minor Version:
Component: Formatting Keywords: has-patch needs-testing gsoc
Focuses: Cc:

Description

When smilies are not converted to images they still should not wrap on line-break.

Attachments (3)

smilies-nowrap-20080119.patch (1.1 KB) - added by gpoul 6 years ago.
smilies-nowrap-20081212.patch (1.9 KB) - added by gpoul 5 years ago.
5689.diff (1.8 KB) - added by wojtek.szkutnik 4 years ago.

Download all attachments as: .zip

Change History (11)

comment:1 gpoul6 years ago

ATTN: the patch above does not yet also apply the changes from changeset:340

comment:2 gpoul5 years ago

uploaded new patch for wordpress 2.7 which is basically the same. I've reviewed changeset:340 and this seems to be addressed.

comment:3 Nicholas915 years ago

  • Cc dragos.nicholas@… added
  • Keywords has-patch added

comment:4 Denis-de-Bernardy5 years ago

  • Component changed from General to Formatting
  • Owner anonymous deleted
  • Priority changed from normal to low
  • Severity changed from normal to minor

comment:5 Denis-de-Bernardy5 years ago

  • Keywords needs-patch added; has-patch removed
  • Milestone changed from 2.9 to Future Release

comment:6 wojtek.szkutnik4 years ago

  • Cc wojtek.szkutnik@… added
  • Keywords has-patch needs-testing gsoc added; needs-patch removed

wojtek.szkutnik4 years ago

comment:7 mdbitz5 months ago

  • Cc matt@… added

Upon review of the smilies function I believe we should not make this change.

The current logic for recognizing smilies requires spacing around the smilies as such there should be no need to add extra processing to wrap textual smilies when use-smilies option is disabled.

Vote to close this as won't fix

comment:8 nacin3 months ago

  • Milestone Future Release deleted
  • Resolution set to wontfix
  • Status changed from new to closed

Unchecking "Use smilies," to me, tells me you have no emotion. Or less glibly, that you want no handling at all, because you aren't using smilies and don't want anything to ever be interpreted as a smiley. Say, if you're a major news organization.

Given how long this ticket has been around, seems like it also never picked up any traction. I'm quite comfortable closing this based on mdbitz's recommendation.

Note: See TracTickets for help on using tickets.