Percent sign (%) in title leads to unusable permalinks

[MC_incubus]

The percent sign (%) in entry titles is incorrectly put into the post slug, breaking the permalink for that entry.

[Kitten]

Reminder sent to MC_incubus

I'll look into this.

[Kitten]

This patch fixes this problem by removing '%' signs from the url completely. Tested, and will clean up old posts that have '%' signs in the title if they're opened for editing and re-saved.

[stilgar]

This is still the case in WordPress 2.0.2.

The problem isn't that the permalink contains '%', this can be allowed, but that the get_permalink function in template-functions-links.php doesn't urlencode $post->post_name, so an invalid url is generated.

[majelbstoat]

Not sure this is useful as it stands. For me, all that this patch seems to do is to make Firefox's status bar less readable:

/path/to/permalink/これは何ですか｡/

which is a readable Japanese permalink in the status bar becomes:

/path/to/permalink/2006/07/05/%e3%81%93%e3%82%8c%e3%81%af%e4%bd%95%e3%81%a7%e3%81%99%e3%81%8b%ef%bd%a1/

which isn't so useful. In IE there is no difference, as with or without this patch the URL is seemingly automatically encoded by the browser. Even without the patch applied, Firefox automatically encodes the link correctly. I haven't tried on other browsers, but I imagine that most (all?) modern ones will behave nicely. Besides which doesn't sanitize_title_with_dashes() already sort out the post-slug as it is created?

In any case, this patch doesn't fix the problem as the above permalink still gives a 404 for me on latest trunk even after it is applied. It looks like the permalink containing octets isn't matching the regular expression rules correctly, though I can't see why.

Jamie.

[majelbstoat]

I believe I've found the problem. In parse_request() in classes.php, the path info is stripped from the end of the requested URI. However, the path is not URI encoded, so it fails to match in the str_replace. This patch urlencodes the path info (minus slashes) so it can be tested properly.

With the patch applied, all permalinks, including encoded ones, are followable.

[majelbstoat]

urlencode pathinfo before we try to match it in parse_request()

[majelbstoat]

On second thoughts, urlencoding everything in the path could break plugins that do rewrite rules checking. This new patch only encodes '%' to '%25', which still fixes the non-followable permalinks problem, without potentially causing problems elsewhere.

[majelbstoat]

Only encode the % sign.

[ryan]

(In [4195]) Encode percent to avoid broken permalinks. Props majelbstoat. fixes #569

[ryan]

(In [4243]) Encode percent to avoid broken permalinks. Props majelbstoat. fixes #569

[(none)]

Milestone 2.0.5 deleted