Creating taxonomy templates for specific terms are wrongly displayed as not found

[franz00]

Summary
Tag and category template creation for specific item are wrongly displayed as not found despite being successfully created. This doesn't happen to all items tag/category templates creation or other template options.

Steps to reproduce

1. Activate Twenty Twenty-Three theme.
2. Create a new tag or category template for specific item.
3. Observe the success notification at the bottom and Not Found: (template_name) at the top toolbar or at the template list.

Expected result
The successfully created templates should not be reported as not found.

Accompanying images
Template editor ​https://i.imgur.com/SkXaUm8.png
Template list ​https://i.imgur.com/A7tYqsj.png

[franz00]

Update: the problem still persist on the 6.1 rc3.
Here's the reference gif image. ​https://imgur.com/a/bcgRIkS

[mikachan]

Thanks for reporting this. I've opened an issue upstream: ​https://github.com/WordPress/gutenberg/issues/45374

[desrosj]

Going to close this out as reported-upstream. This likely can only be solved through changes to the block editor itself and not within themes.

[franz00]

Thank you for reporting it to upstream.

Fixes: ​https://github.com/WordPress/gutenberg/issues/45374, https://core.trac.wordpress.org/ticket/56902.

This issue does not affect the Gutenberg plugin and is a core-specific regression introduced in
​https://github.com/WordPress/wordpress-develop/commit/628e83d157dd7e987c3c58c69b9a7c2bc173e2a9.
According to the docs ​https://developer.wordpress.org/reference/classes/wp_term_query/query/ WP_Term_Query:->query( string|array $query ) returns [WP_Term][]|int[]|string[]|string, and we were retrieving an inexistent object property terms making it always empty and look like the taxonomy did not exist.
This PR fixes the issue.

[jorgefilipecosta]

In 54751:

Fix: Category specific templates always appear as not found.

According to the docs in developer.wordpress.org/reference/classes/wp_term_query/query WP_Term_Query:->query( string|array $query ) returns WP_Term[]|int[]|string[]|string, and we were using an inexistent object property terms making it always empty and look like the taxonomy did not exist.

Props mamaduka, mikachan, ockham, franz00.
See #56902.

Committed at ​https://github.com/WordPress/wordpress-develop/commit/001528df12d47bd817a399e47ee3da46c4396fdb.

[desrosj]

This is not specifically related to themes, so I'm reclassifying it to the Editor component.

[desrosj]

In 54767:

Fix: Category specific templates always appear as not found.

According to the docs in developer.wordpress.org/reference/classes/wp_term_query/query WP_Term_Query:->query( string|array $query ) returns WP_Term[]|int[]|string[]|string, and we were using an inexistent object property terms making it always empty and look like the taxonomy did not exist.

Props mamaduka, mikachan, ockham, franz00.
Merges [54751] to the 6.1 branch.
Fixes #56902.