Make WordPress Core

#56903 closed defect (bug) (fixed)

Separator colors defined using background within theme.json for style variations are ignored

Reported by: cbravobernal's profile cbravobernal Owned by: desrosj's profile desrosj
Milestone: 6.1.1 Priority: normal
Severity: normal Version:
Component: Editor Keywords: has-patch has-unit-tests fixed-major
Focuses: Cc:

Change History (15)

This ticket was mentioned in PR #3522 on WordPress/wordpress-develop by @cbravobernal.


18 months ago
#1

  • Keywords has-patch has-unit-tests added

@Mamaduka commented on PR #3522:


18 months ago
#2

@c4rl0sbr4v0, the CI checks are failing. We'll need to fix them before we can commit this into the trunk.

@cbravobernal commented on PR #3522:


18 months ago
#3

@c4rl0sbr4v0, the CI checks are failing. We'll need to fix them before we can commit this into the trunk.

Thanks for the ping, @Mamaduka! It was just some blank spaces, fixed!

#4 @desrosj
18 months ago

  • Milestone changed from Awaiting Review to 6.1.1

Moving to 6.1.1 for consideration.

This ticket was mentioned in Slack in #core by jeffpaul. View the logs.


17 months ago

#6 @desrosj
17 months ago

  • Component changed from General to Editor
  • Summary changed from Backport bugfix on separator block and theme.json #44943 to Separator colors definied using background within theme.json for style variations are ignored

This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.


17 months ago

This ticket was mentioned in PR #3608 on WordPress/wordpress-develop by @flixos90.


17 months ago
#8

Trac ticket: https://core.trac.wordpress.org/ticket/56903

@flixos90 commented on PR #3522:


17 months ago
#9

In order to get this committed shortly for the 6.1.1 RC, I've opened an iteration PR to this #3608 since this PR branch couldn't be updated.

#10 @flixos90
17 months ago

Opened a new PR https://github.com/WordPress/wordpress-develop/pull/3608 (port of the original PR with additional suggestion applied), so that we can hopefully commit this shortly.

#11 @JeffPaul
17 months ago

  • Summary changed from Separator colors definied using background within theme.json for style variations are ignored to Separator colors defined using background within theme.json for style variations are ignored

#12 @desrosj
17 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 54821:

Editor: Correctly style separator blocks when only a background-color is defined.

When separator blocks are configured using only a background-color, they are shown correctly within the editor but not on the front end.

This changes WP_Theme_JSON to detect this scenario and move the background-color value to just color when both color and border-color are missing.

Props cbravobernal, flixos90, davidbaumwald, hellofromTonya, desrosj, andrewserong, czapla, glendaviesnz, wildworks.
Fixes #56903.

#13 @desrosj
17 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to backport for 6.1.1.

@desrosj commented on PR #3608:


17 months ago
#14

Merged in https://core.trac.wordpress.org/changeset/54821. Noting the E2E failure above was due to the issue fixed in https://core.trac.wordpress.org/changeset/54819.

#15 @desrosj
17 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 54822:

Editor: Correctly style separator blocks when only a background-color is defined.

When separator blocks are configured using only a background-color, they are shown correctly within the editor but not on the front end.

This changes WP_Theme_JSON to detect this scenario and move the background-color value to just color when both color and border-color are missing.

Props cbravobernal, flixos90, davidbaumwald, hellofromTonya, desrosj, andrewserong, czapla, glendaviesnz, wildworks.
Merges [54821] to the 6.1 branch.
Fixes #56903.

Note: See TracTickets for help on using tickets.