Opened 2 years ago
Closed 2 years ago
#56903 closed defect (bug) (fixed)
Separator colors defined using background within theme.json for style variations are ignored
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.1.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Editor | Keywords: | has-patch has-unit-tests fixed-major |
Focuses: | Cc: |
Description
PHP Backport for https://github.com/WordPress/gutenberg/pull/44943
Change History (15)
This ticket was mentioned in PR #3522 on WordPress/wordpress-develop by @cbravobernal.
2 years ago
#1
- Keywords has-patch has-unit-tests added
@Mamaduka commented on PR #3522:
2 years ago
#2
@c4rl0sbr4v0, the CI checks are failing. We'll need to fix them before we can commit this into the trunk.
@cbravobernal commented on PR #3522:
2 years ago
#3
@c4rl0sbr4v0, the CI checks are failing. We'll need to fix them before we can commit this into the trunk.
Thanks for the ping, @Mamaduka! It was just some blank spaces, fixed!
This ticket was mentioned in Slack in #core by jeffpaul. View the logs.
2 years ago
#6
@
2 years ago
- Component changed from General to Editor
- Summary changed from Backport bugfix on separator block and theme.json #44943 to Separator colors definied using background within theme.json for style variations are ignored
This ticket was mentioned in Slack in #core by hellofromtonya. View the logs.
2 years ago
This ticket was mentioned in PR #3608 on WordPress/wordpress-develop by @flixos90.
2 years ago
#8
- This is basically #3522, with the additional suggestion from https://github.com/WordPress/wordpress-develop/pull/3522#pullrequestreview-1176606228 applied.
- Make sure props for original contributors @c4rl0sbr4v0, @dream-encode, and @hellofromtonya are included.
Trac ticket: https://core.trac.wordpress.org/ticket/56903
@flixos90 commented on PR #3522:
2 years ago
#9
In order to get this committed shortly for the 6.1.1 RC, I've opened an iteration PR to this #3608 since this PR branch couldn't be updated.
#10
@
2 years ago
Opened a new PR https://github.com/WordPress/wordpress-develop/pull/3608 (port of the original PR with additional suggestion applied), so that we can hopefully commit this shortly.
#11
@
2 years ago
- Summary changed from Separator colors definied using background within theme.json for style variations are ignored to Separator colors defined using background within theme.json for style variations are ignored
#12
@
2 years ago
- Owner set to desrosj
- Resolution set to fixed
- Status changed from new to closed
In 54821:
#13
@
2 years ago
- Keywords fixed-major added
- Resolution fixed deleted
- Status changed from closed to reopened
Reopening to backport for 6.1.1.
2 years ago
#14
Merged in https://core.trac.wordpress.org/changeset/54821. Noting the E2E failure above was due to the issue fixed in https://core.trac.wordpress.org/changeset/54819.
Backport for https://github.com/WordPress/gutenberg/pull/44943
Trac ticket: https://core.trac.wordpress.org/ticket/56903#ticket