WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

#56903 closed defect (bug) (fixed)

Separator colors defined using background within theme.json for style variations are ignored

Reported by: cbravobernal Owned by: desrosj
Priority: normal Milestone: 6.1.1
Component: Editor Version:
Severity: normal Keywords: has-patch has-unit-tests fixed-major
Cc: Focuses:

Description

PHP Backport for ​https://github.com/WordPress/gutenberg/pull/44943

Change History (15)

This ticket was mentioned in ​PR #3522 on ​WordPress/wordpress-develop by ​@cbravobernal.
4 years ago #1

  • Keywords has-patch has-unit-tests added

Backport for ​https://github.com/WordPress/gutenberg/pull/44943

Trac ticket: https://core.trac.wordpress.org/ticket/56903#ticket

​@Mamaduka commented on ​PR #3522:
4 years ago #2

@c4rl0sbr4v0, the CI checks are failing. We'll need to fix them before we can commit this into the trunk.

​@cbravobernal commented on ​PR #3522:
4 years ago #3

@c4rl0sbr4v0, the CI checks are failing. We'll need to fix them before we can commit this into the trunk.

Thanks for the ping, @Mamaduka! It was just some blank spaces, fixed!

#4 @desrosj
4 years ago

  • Milestone Awaiting Review → 6.1.1

Moving to 6.1.1 for consideration.

This ticket was mentioned in ​Slack in #core by jeffpaul. ​View the logs.
4 years ago

#6 @desrosj
4 years ago

  • Component General → Editor
  • Summary Backport bugfix on separator block and theme.json #44943 → Separator colors definied using background within theme.json for style variations are ignored

This ticket was mentioned in ​Slack in #core by hellofromtonya. ​View the logs.
4 years ago

This ticket was mentioned in ​PR #3608 on ​WordPress/wordpress-develop by ​@flixos90.
4 years ago #8

Trac ticket: https://core.trac.wordpress.org/ticket/56903

​@flixos90 commented on ​PR #3522:
4 years ago #9

In order to get this committed shortly for the 6.1.1 RC, I've opened an iteration PR to this #3608 since this PR branch couldn't be updated.

#10 @flixos90
4 years ago

Opened a new PR ​https://github.com/WordPress/wordpress-develop/pull/3608 (port of the original PR with additional suggestion applied), so that we can hopefully commit this shortly.

#11 @JeffPaul
4 years ago

  • Summary Separator colors definied using background within theme.json for style variations are ignored → Separator colors defined using background within theme.json for style variations are ignored

#12 @desrosj
4 years ago

  • Owner set to desrosj
  • Resolution → fixed
  • Status new → closed

In 54821:

Editor: Correctly style separator blocks when only a background-color is defined.

When separator blocks are configured using only a background-color, they are shown correctly within the editor but not on the front end.

This changes WP_Theme_JSON to detect this scenario and move the background-color value to just color when both color and border-color are missing.

Props cbravobernal, flixos90, davidbaumwald, hellofromTonya, desrosj, andrewserong, czapla, glendaviesnz, wildworks.
Fixes #56903.

#13 @desrosj
4 years ago

  • Keywords fixed-major added
  • Resolution fixed
  • Status closed → reopened

Reopening to backport for 6.1.1.

​@desrosj commented on ​PR #3608:
4 years ago #14

Merged in https://core.trac.wordpress.org/changeset/54821. Noting the E2E failure above was due to the issue fixed in https://core.trac.wordpress.org/changeset/54819.

#15 @desrosj
4 years ago

  • Resolution → fixed
  • Status reopened → closed

In 54822:

Editor: Correctly style separator blocks when only a background-color is defined.

When separator blocks are configured using only a background-color, they are shown correctly within the editor but not on the front end.

This changes WP_Theme_JSON to detect this scenario and move the background-color value to just color when both color and border-color are missing.

Props cbravobernal, flixos90, davidbaumwald, hellofromTonya, desrosj, andrewserong, czapla, glendaviesnz, wildworks.
Merges [54821] to the 6.1 branch.
Fixes #56903.

Note: See TracTickets for help on using tickets.