Prime network options in a single cache call using wp_cache_get_multiple

[spacedmonkey]

When wp_load_core_site_options change the logic to call wp_cache_get_multiple priming important network options in cache in a single cache call.

Trac ticket: https://core.trac.wordpress.org/ticket/56913

Desperately want to pre-register these keys using register_meta() with some new autoload attribute 😬

Desperately want to pre-register these keys using register_meta() with some new autoload attribute 😬

Where I personally agree, I feel like that is a larger discussion. This ticket is simple and easier to commit. If this get "fixed" by using the meta api down the line then so be it.

@JJJ Question, how around using a autoload attribute work for multisite. This function is called early in the bootstrap. So would likely require register settings in a sunrise or advanced cache file. This feels weird and unlikely to happen.

[spacedmonkey]

Would love a review of this as part of 6.3. Pinging @flixos90

[spacedmonkey]

Now that [55146] is merged, fileupload_maxk, upload_space_check_disabled and upload_filetypes no longer needed to be automatically loaded.

This PR is now just to prime caches in object caches in a single call. There is less benefit, but it still useful. Worth committing @mukesh27 @johnjamesjacoby ?

[oglekler]

@spacedmonkey you have a failed Unit-test, could you please have a look and fix it. We are in 9 days until Beta 1 🤷

[spacedmonkey]

@oglekler Still awaiting review. Mind taking a look.

[oglekler]

There is a discussion on the PR itself about improvements.

I tested this patch, it works, we have a time improvement with persistent cache. My suggestion is to commit this like it is now and continue discussion for further improvements separately.

Of course, other testers are welcome to test too.

[spacedmonkey]

I got enough approvals on the PR to commit. I think the discussion should continue as part of the beta process and we can revert if needed.

[spacedmonkey]

In 56061:

Options, Meta APIs: Prime network options in a single cache call using wp_cache_get_multiple.

Tweak the wp_load_core_site_options function, to also prime network options using wp_cache_get_multiple if persistent object cache is present.

Props mukesh27, oglekler, peterwilsoncc, costdev, jeremyfelt, spacedmonkey.
Fixes #56913.

Committed ​https://github.com/WordPress/wordpress-develop/commit/efc70bed11caad16b1e754676543e638b5f8b8f4

[spacedmonkey]

Dev note. ​https://make.wordpress.org/core/2023/07/17/improvements-to-the-cache-api-in-wordpress-6-3/