Make WordPress Core

Opened 19 months ago

Closed 19 months ago

Last modified 19 months ago

#56921 closed enhancement (fixed)

Inconsistency in help tab & small typo

Reported by: nekojonez's profile NekoJonez Owned by: audrasjb's profile audrasjb
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: Help/About Keywords: has-patch commit
Focuses: ui, docs, administration Cc:

Description

Some texts in the help tab are a bit inconsistent.

In the post help tab, in one sentence we use two different things for "post list".

I also found a string where I felt that in an automatic mail sent when deleting your website/account, a word was missing.

Also, I find it a bit strange that for auto updates we use "Learn more:" in front of the link while all other things in the help tab don't have that.

So, I want to make that a bit more consistent.

Change History (10)

This ticket was mentioned in PR #3532 on WordPress/wordpress-develop by @NekoJonez.


19 months ago
#1

  • Keywords has-patch added

I described my changes in the Trac ticket. But the long and short of it is that I was checking some strings for the upcoming 6.1 release in my nl_BE translation and found some odd inconsistent things in the help tabs. With this PR, I want to fix them.

Trac ticket: (https://core.trac.wordpress.org/ticket/56921)

#2 @SergeyBiryukov
19 months ago

  • Milestone changed from Awaiting Review to 6.2

#3 @sabernhardt
19 months ago

  • Component changed from Text Changes to Help/About

#4 @mukesh27
19 months ago

  • Owner set to SergeyBiryukov
  • Status changed from new to assigned

Thanks @NekoJonez for ticket and PR.

PR LGTM and approved. Assign to @SergeyBiryukov for final review.

#5 @audrasjb
19 months ago

  • Owner changed from SergeyBiryukov to audrasjb
  • Status changed from assigned to reviewing

Self assigning for final review.

#6 @SergeyBiryukov
19 months ago

Thanks for the PR!

I'm not sure I like the first change :) The suggested sentence repeats "post list" twice, and it's also "post list" in the first instance and "posts list" in the second:

You can filter the post list by post status using the text links above the posts list to only show posts with that status. The default view is to show all posts.

The original sentence seems easier to read to me, and avoids unnecessary repetition:

You can filter the list of posts by post status using the text links above the posts list to only show posts with that status. The default view is to show all posts.

The other changes look good to me.

#7 @audrasjb
19 months ago

  • Keywords commit added

I modified the PR accordingly.
Marking this for commit.

Last edited 19 months ago by audrasjb (previous) (diff)

#8 @audrasjb
19 months ago

  • Resolution set to fixed
  • Status changed from reviewing to closed

In 54839:

Help/About: Fix inconsistency in auto-updates help tabs.

This changeset ensures the wording of auto-updates related help tabs is consistent with other help tabs.

Props NekoJonez, SergeyBiryukov, mukesh27, audrasjb.
Fixes #56921.

#9 @audrasjb
19 months ago

In 54840:

Text Changes: Improve the wording of the email sent to confirm site deletion.

Props NekoJonez, SergeyBiryukov, mukesh27, audrasjb.
See #56921.

@audrasjb commented on PR #3532:


19 months ago
#10

Fixed in https://core.trac.wordpress.org/changeset/54839 and https://core.trac.wordpress.org/changeset/54840.
I separated the patch in two commits to give them there own separate commit description.

Note: See TracTickets for help on using tickets.