WordPress.org
Get WordPress

Make WordPress Core

Changes between Version 1 and Version 2 of Ticket #56930, comment 38


Ignore:
Timestamp:
02/03/2023 07:30:01 PM (22 months ago)
Author:
antonvlasenko
Comment:

Legend:

Unmodified
Added
Removed
Modified

  • Ticket #56930, comment 38

    v1 v2  
    1 > Was that just because of what you highlighted in your note (npm run build:dev overriding the fix)?
     1>Thank you for giving this a detailed test
     2You are welcome!
    23
     4> Was that just because of what you highlighted in your note (`npm run build:dev` overriding the fix)?
    35Yes, that's absolutely correct, @flixos90! I had to edit the test report when I realized why the fix "wasn't working."
    46Also, I've [https://github.com/WordPress/wordpress-develop/pull/3560#pullrequestreview-1283349467 reviewed] the code. It looks good to me, although I'm not an expert on rendering `core/image` blocks.
     7