Make WordPress Core

Opened 19 years ago

Closed 19 years ago

#5694 closed enhancement (fixed)

Flexible comment counter bubble

Reported by: sambauers Owned by: matt
Priority: normal Milestone: 2.5
Component: Administration Version:
Severity: normal Keywords:
Cc: Focuses:

Description

Flexible and re-sizable comment counter bubble.

No limits on comment count need be imposed anymore.

Only tested in Safari and Firefox on Mac.

Rounded corners only available where -khtml-border-radius or border-radius are supported (-moz-border-radius looks terrible) if you want rounded corners via background images we'll need some more images and otherwise redundant markup.

Attachments (6)

comment-bubble.diff (2.5 KB ) - added by sambauers 19 years ago.
comment-stalk.gif (525 bytes ) - added by sambauers 19 years ago.
comment-pill-left.gif (82 bytes ) - added by sunburntkamel 19 years ago.
left side, flexible background
comment-pill-right.gif (61 bytes ) - added by sunburntkamel 19 years ago.
right side
awaiting-mod.diff (4.2 KB ) - added by sunburntkamel 19 years ago.
diff to menu.php, menu-headers.php, wp-admin.css
comment-buuble-count-fix.diff (1.6 KB ) - added by nbachiyski 19 years ago.

Download all attachments as: .zip

Change History (12)

#1 @Speedboxer
19 years ago

In IE7, when you do anything that affects the comment count, the "bubble" just has the cornor image and says "NaN".

#2 follow-up: @sunburntkamel
19 years ago

IE7 is a pain. I'm still working on that, but it works in FF/Safari/Opera.

Rather than adding markup, i've added classes to the LI's

@sunburntkamel
19 years ago

left side, flexible background

@sunburntkamel
19 years ago

right side

@sunburntkamel
19 years ago

diff to menu.php, menu-headers.php, wp-admin.css

#3 in reply to: ↑ 2 @Speedboxer
19 years ago

Replying to sunburntkamel:

IE7 is a pain. I'm still working on that, but it works in FF/Safari/Opera.

Rather than adding markup, i've added classes to the LI's

awaiting-mod.diff is even worse in IE7, half of it gets cut off, including the number. Even worse in IE6 (although, the whole Admin is fairly broken in IE6, too).

It get's screwed up when you zoom in in FF2, also.

#4 @matt
19 years ago

  • Resolutionfixed
  • Status newclosed

(In [6638]) Try a different comment bubble, fixes #5694. Hat tip: sambauers.

#5 @nbachiyski
19 years ago

  • Resolution fixed
  • Status closedreopened

Since the fix added an internal span to the bubble the html of .comment-count wasn't the comment count, but the span, which caused {{{Nan}}s in the bubble.

The patch uses .comment-count span as a selector and adds an internal span to the submenu count in parens, so that both can be updated using the same code.

#6 @ryan
19 years ago

  • Resolutionfixed
  • Status reopenedclosed

(In [6678]) Comment bubble count fix from nbachiyski. fixes #5694

Note: See TracTickets for help on using tickets.