Opened 18 years ago
Closed 18 years ago
#5694 closed enhancement (fixed)
Flexible comment counter bubble
| Reported by: |
|
Owned by: |
|
|---|---|---|---|
| Milestone: | 2.5 | Priority: | normal |
| Severity: | normal | Version: | |
| Component: | Administration | Keywords: | |
| Focuses: | Cc: |
Description
Flexible and re-sizable comment counter bubble.
No limits on comment count need be imposed anymore.
Only tested in Safari and Firefox on Mac.
Rounded corners only available where -khtml-border-radius or border-radius are supported (-moz-border-radius looks terrible) if you want rounded corners via background images we'll need some more images and otherwise redundant markup.
Attachments (6)
Change History (12)
#2
follow-up:
↓ 3
@
18 years ago
IE7 is a pain. I'm still working on that, but it works in FF/Safari/Opera.
Rather than adding markup, i've added classes to the LI's
#3
in reply to:
↑ 2
@
18 years ago
Replying to sunburntkamel:
IE7 is a pain. I'm still working on that, but it works in FF/Safari/Opera.
Rather than adding markup, i've added classes to the LI's
awaiting-mod.diff is even worse in IE7, half of it gets cut off, including the number. Even worse in IE6 (although, the whole Admin is fairly broken in IE6, too).
It get's screwed up when you zoom in in FF2, also.
#5
@
18 years ago
- Resolution fixed deleted
- Status changed from closed to reopened
Since the fix added an internal span to the bubble the html of .comment-count wasn't the comment count, but the span, which caused {{{Nan}}s in the bubble.
The patch uses .comment-count span as a selector and adds an internal span to the submenu count in parens, so that both can be updated using the same code.
In IE7, when you do anything that affects the comment count, the "bubble" just has the cornor image and says "NaN".