Make WordPress Core

Opened 2 years ago

Closed 8 months ago

Last modified 6 months ago

#56949 closed defect (bug) (fixed)

Twenty Twenty-Three: Screenshot of the new default theme

Reported by: kafleg's profile kafleg Owned by: karmatosed's profile karmatosed
Milestone: 6.6 Priority: normal
Severity: normal Version: 6.1
Component: Bundled Theme Keywords: dev-feedback has-patch commit
Focuses: Cc:

Description

The screenshot of the new default theme TT3 is showing the backend editor, not the front view of it. Our theme guideline is,

  • The screenshot must not look like an advertisement. The reviewer can subjectively ask you to change screenshots if they find that it is not appropriate.

https://make.wordpress.org/themes/handbook/review/required/

It seems that showing Global Styles in the screenshot is like an advertisement of the feature. I'm wondering if other themes can also update the screenshot showing Global Styles or Editor.

Attachments (1)

screenshot.png (79.8 KB) - added by SergeyBiryukov 8 months ago.

Download all attachments as: .zip

Change History (19)

#2 @poena
2 years ago

It is a default feature, to me no different than displaying a navigation menu, social links, widgets or site logo.

It is not false advertising - pretending to have features that don’t exist, nor actual advertising "buy our premium products", which the requirements are meant to prevent.

#3 @shivashankerbhatta
2 years ago

This seems different just because they have used the theme screenshot from the backend editor. While reading the discussion, https://github.com/WordPress/twentytwentythree/issues/163 they want to show the available theme styles which are listed under the theme screenshots interactively and have no need to display from the image.

#4 @poena
2 years ago

The style variations are only visible on the wordpress.org theme directory, not on the theme screens in WordPress.

#5 @SergeyBiryukov
22 months ago

  • Summary changed from Screenshot of the new default theme TT3 to Twenty Twenty-Three: Screenshot of the new default theme

#6 @karmatosed
10 months ago

  • Keywords dev-feedback added; 2nd-opinion removed

I don't mind this being shown but I want to be sensitive to where everyone is feeling today as this ticket has sat for a while. Can I ask how @kafleg, @shivashankerbhatta and @poena you feel today on where this should go?

To be clear, my recommendation would be we close this with 'won't fix' as it has been this way for a while and doesn't appear to have been settled.

#7 @poena
10 months ago

Because there are more ways to view the variations now, both in the theme directory and in the Site Editor, I wouldn't mind if the screenshot was replaced with one that does not show the variations.

#8 @karmatosed
10 months ago

  • Keywords needs-patch added

@poena ok then that's fairly clear feelings and I am happy to respect those. I will add a 'needs-patch' to this so we can get something as a suggestion if everyone does agree this time.

This ticket was mentioned in PR #6451 on WordPress/wordpress-develop by @poena.


9 months ago
#9

  • Keywords has-patch added; needs-patch removed

Replace the screenshot in Twenty Twenty-Three to remove the visible style variation sidebar.

This image is 9.44Kib larger than the old, but I think there is an action to compress the image when committing?

Trac ticket: https://core.trac.wordpress.org/ticket/56949

#10 @poena
9 months ago

  • Milestone changed from Awaiting Review to 6.6

#11 @poena
9 months ago

Here is the link to the image comparison on GitHub: https://github.com/WordPress/wordpress-develop/pull/6451/files

@sabernhardt commented on PR #6451:


9 months ago
#12

r57322 added themes' images to a Grunt task, so this should be compressed automatically. If you would like to minify manually, TinyPNG can reduce the size to less than 38KB, and I did not notice a significant visual difference.

For the image content, I like that it shows the theme's Call to Action pattern (WordPress.com's screenshot does not). Typography and color choices can vary greatly between style variations, but the pattern is common to all variations and special to the theme.

@poena commented on PR #6451:


9 months ago
#13

The screenshot is from the same demo, 2023.wordpress.net. I hid the featured images because I didn't know their license.

#14 follow-up: @karmatosed
9 months ago

@poena unless I am mistaken the patch seems to not be applying. Is it still working?

#15 in reply to: ↑ 14 @SergeyBiryukov
8 months ago

Replying to karmatosed:

unless I am mistaken the patch seems to not be applying. Is it still working?

Yeah, the patch command does not work on binary files, the screenshot has to be downloaded and replaced manually.

I'm attaching the screenshot proposed in @poena's PR, minified after running npm run grunt precommit:image.

#16 @karmatosed
8 months ago

  • Keywords commit added

Thank you @SergeyBiryukov I will now go through this.

#17 @karmatosed
8 months ago

  • Owner set to karmatosed
  • Resolution set to fixed
  • Status changed from new to closed

In 58179:

Twenty Twenty-Three: Updates Screenshot.

The screenshot wasn't showing the front view. This now resolves it to fit guidelines.

Props kafleg, poena, shivashankerbhatta, SergeyBiryukov.
Fixes #56949.

@SergeyBiryukov commented on PR #6451:


6 months ago
#18

Thanks for the PR! This was merged in r58179.

Note: See TracTickets for help on using tickets.