Changes between Version 1 and Version 2 of Ticket #56975, comment 77
- Timestamp:
- 01/22/2023 12:00:05 PM (2 years ago)
Legend:
- Unmodified
- Added
- Removed
- Modified
-
Ticket #56975, comment 77
v1 v2 3 3 I found myself in a layover with a half an hour to kill and re-checked the conversations in this ticket. Prepared https://github.com/WordPress/wordpress-develop/pull/3887 I won't be fully available until Wednesday, so feel free to address any feedback and merge. I didn't remove the existing non-persistent group or the function wp_clean_theme_json_cache, as it's going to be necessary for the wp_get_global_settings anyway. If it is not, it can be removed in a separate PR as well. 4 4 5 My advice would still be not doing this and follow the approach at https://core.trac.wordpress.org/ticket/56975?cnum_edit=77#comment:75 However, it's more important to me to ship this code, hence why I created the PR in order to help as much as possible to get this done, if most folks think this is the best wayforward.5 My advice would still be not using the static cache and follow the approach at https://core.trac.wordpress.org/ticket/56975?cnum_edit=77#comment:75 However, it's more important to me to wrap up this conversation and focus on shipping the other two tickets. If most folks think this is the best way forward, let's ship and move forward. 6 6 7 7 @otto42 Note how using the static cache leaks into the API via parameter to clean it upon certain events: