WordPress.org

Make WordPress Core

Opened 7 years ago

Closed 7 years ago

#5699 closed enhancement (fixed)

get_col() instead of get_results() for increased performance

Reported by: fitztrev Owned by:
Milestone: 2.5 Priority: low
Severity: minor Version:
Component: General Keywords:
Focuses: Cc:

Description

Using get_results() is overkill for what's being selected in this query.

get_col() should have faster parsing times.

Attachments (2)

get_col.diff (566 bytes) - added by fitztrev 7 years ago.
get_col2.diff (691 bytes) - added by fitztrev 7 years ago.

Download all attachments as: .zip

Change History (5)

@fitztrev7 years ago

comment:1 @ryan7 years ago

I think do_trackbacks($trackback->ID) would need to become do_trackbacks($trackback).

@fitztrev7 years ago

comment:2 @fitztrev7 years ago

That's absolutely correct. Here is the updated patch. Tested, this time.

comment:3 @ryan7 years ago

  • Resolution set to fixed
  • Status changed from new to closed

(In [6640]) get_col() instead of get_results(). Props fitzrev. fixes #5699

Note: See TracTickets for help on using tickets.