Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #56990, comment 39


Ignore:
Timestamp:
02/08/2023 11:07:48 PM (16 months ago)
Author:
sabernhardt
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #56990, comment 39

    initial v1  
    11Thanks @patrickmeenan for the additional feedback! There isn't really a precedent here, but one thing we cannot do is incorporate those styles in the main stylesheet, as it is externally controlled by whichever WordPress theme is currently active. So it needs to be separate unfortunately.
    22
    3 @wpgurudev @scruffian Based on the above feedback, while the performance difference is negligible, I'd still lean towards inlining it for slightly more benefit. The performance test from https://core.trac.wordpress.org/ticket/56990#comment:29 doesn't show a clear benefit in either direction, as we have to consider the variance between test runs is considerable.
     3@wpgurudev @scruffian Based on the above feedback, while the performance difference is negligible, I'd still lean towards inlining it for slightly more benefit. The performance test from comment:29 doesn't show a clear benefit in either direction, as we have to consider the variance between test runs is considerable.
    44
    55That being said, it's also safe to say it's not a high priority issue to address in terms of performance.