Make WordPress Core

#56994 closed defect (bug) (fixed)

Twenty Seventeen: Remove letter-spacing from Farsi/Persian alphabet

Reported by: amirrezatm's profile amirrezatm Owned by: audrasjb's profile audrasjb
Milestone: 6.2 Priority: normal
Severity: normal Version: 4.7
Component: Bundled Theme Keywords: has-patch has-screenshots commit
Focuses: css Cc:

Description

Farsi/Persian has a non-Latin alphabet and the letter-spacing property in style.css really exhausts eyes when reading pages in twenty-seventeen theme

there is a section starting with:

/* Remove letter-spacing for all non-latin alphabets */

in style.css that lists the languages that have letter-spacing omitted from their properties and it lacks Persian, simply add a

html[lang="fa-IR"] * 

and almost 120mln more people can use 2017 for their blog including me :D

Attachments (4)

style.css (86.4 KB) - added by itpathsolutions 19 months ago.
Added a letter spacing for html[lang="fa-IR"]
56994.patch (1.4 KB) - added by sabernhardt 19 months ago.
resets letter-spacing for Persian and Urdu, changing CSS selector to include any Persian locale
Before patch.png (1.6 MB) - added by mukesh27 19 months ago.
After patch.png (1.6 MB) - added by mukesh27 19 months ago.

Change History (10)

@itpathsolutions
19 months ago

Added a letter spacing for html[lang="fa-IR"]

@sabernhardt
19 months ago

resets letter-spacing for Persian and Urdu, changing CSS selector to include any Persian locale

#1 @sabernhardt
19 months ago

  • Component changed from Themes to Bundled Theme
  • Keywords has-patch needs-testing added
  • Milestone changed from Awaiting Review to 6.2
  • Severity changed from minor to normal
  • Summary changed from Removing letter-spacing from Farsi/Persian alphabet to Twenty Seventeen: Remove letter-spacing from Farsi/Persian alphabet
  • Type changed from enhancement to defect (bug)
  • Version changed from 6.1 to 4.7

Hi and thanks for the report!

Urdu was missing from that list, too. I also changed the selector for all Persian styles to include the Afghanistan locale.

#2 @mukesh27
19 months ago

  • Keywords has-screenshots added; needs-testing removed

Thanks @amirrezatm for the ticket.

@sabernhardt 56994.patch LGTM. Attached screenshot for before/after patch.

#3 @amirrezatm
19 months ago

It looks great now thank you!

#4 @sabernhardt
19 months ago

  • Keywords commit added

#5 @audrasjb
19 months ago

  • Owner set to audrasjb
  • Status changed from new to accepted

Looks good to me. Self assigning for commit consideration.

#6 @audrasjb
19 months ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 54838:

Twenty Seventeen: Improve letter-spacing reset for non-latin alphabets.

This changeset resets letter-spacing for Persian and Urdu, and changes the related CSS selector to include any Persian locale.

Props amirrezatm, itpathsolutions, sabernhardt, mukesh27.
Fixes #56994.

Note: See TracTickets for help on using tickets.