Make WordPress Core

Opened 4 years ago

Closed 4 weeks ago

#56998 closed defect (bug) (wontfix)

Twenty Twenty: large margins between widgets in footer (in admin area they seem smaller)

Reported by: warrior7089 Owned by:
Priority: normal Milestone:
Component: Bundled Theme Version:
Severity: normal Keywords: close
Cc: Focuses: css

Description

Hi,

There are large margins between widgets in footer in twenty twenty theme. ​https://ibb.co/qgdQGgV

In admin area they seem smaller and look better. ​https://ibb.co/9hPLwdj

Got advice to open trac ticket after opening support ticket at ​https://wordpress.org/support/topic/large-margins-between-widgets-in-footer-in-admin-area-they-seem-smaller/ and fixing the issue using css.

Change History (6)

#1 @sabernhardt
4 years ago

  • Component General → Bundled Theme
  • Focuses css added
  • Summary large margins between widgets in footer in twenty twenty theme (in admin area they seem smaller) → Twenty Twenty: large margins between widgets in footer (in admin area they seem smaller)

#2 @sabernhardt
3 years ago

  • Keywords needs-patch added

Every footer widget after the first has a large top margin on the front: 5rem on larger screens and 3rem on smaller screens.

.widget {
	margin-top: 3rem;
}
.widget:first-child {
	margin-top: 0;
}
@media ( min-width: 700px ) {
	.footer-widgets .widget {
		margin-top: 5rem;
	}
	.footer-widgets .widget:first-child {
		margin-top: 0;
	}
}

The margin has been that way in Twenty Twenty since the first version (it was even in the ​first version of Chaplin, which was the foundation for Twenty Twenty).

I do not recommend changing the front after people have been using this theme, though maybe the Widgets editor could reflect the 3rem margin (the editor canvas is less than 700 pixels wide).

.wp-block-widget-area__inner-blocks .block-editor-block-list__layout > .wp-block {
	margin-top: 3rem;
}
.wp-block-widget-area__inner-blocks .block-editor-block-list__layout > .wp-block:first-child {
	margin-top: 0;
}

#3 @sabernhardt
3 years ago

Thanks for the report!

#4 @karmatosed
3 years ago

@sabernhardt if I am understanding correctly you are recommending to only change within the editor the margins - please correct me if I am mistaken. I think personally if that is the case, I wouldn't recommend we do this at this time, what do you feel today about doing this?

#5 @karmatosed
4 weeks ago

  • Keywords close added; needs-patch removed

It's been a while, let's look at getting a solution here. The large gap between footer widgets has been there since Twenty Twenty launched. I would therefore suggest we leave it as it is. Changing the front end would tighten every existing site, and changing only the editor would make the editor show a different gap from the published page. I suggest we close this.

#6 @karmatosed
4 weeks ago

  • Milestone Awaiting Review
  • Resolution → wontfix
  • Status new → closed

Closing for now, we can always reopen any ticket.

Note: See TracTickets for help on using tickets.