WordPress.org
Get WordPress

Make WordPress Core

Opened 2 years ago

Closed 14 months ago

Last modified 14 months ago

#56999 closed enhancement (fixed)

Twenty Twenty-Three: rename Comments template part

Reported by: mikachan's profile mikachan Owned by: swissspidy's profile swissspidy
Milestone: 6.5 Priority: normal
Severity: normal Version: 6.1
Component: Bundled Theme Keywords: has-patch commit
Focuses: Cc:

Description

There has been a previous discussion around renaming the Comments template part in Twenty Twenty-Three, as this may cause confusion with the Comments block. They both have the same name, which means they appear in a very similar way in the block inserter:

https://cldup.com/vhu7Ua5Txj.png

The proposed solution was to rename the template part from "Comments" to "Comments Template Part".

Original discussion in Gutenberg: ​https://github.com/WordPress/gutenberg/issues/45084#issuecomment-1284474571

Original PR (that didn't make it into 6.1): ​https://github.com/WordPress/twentytwentythree/pull/289

Change History (7)

This ticket was mentioned in ​PR #3571 on ​WordPress/wordpress-develop by ​@mikachan.
2 years ago #1

  • Keywords has-patch added

This renames the Comments template part to 'Comments Template Part', to reduce confusion with the 'Comments' block when viewing both in the inserter.

https://i0.wp.com/user-images.githubusercontent.com/1645628/200033049-03a359ec-8bdd-47ec-8b70-ee4ad784c289.png

Trac ticket: https://core.trac.wordpress.org/ticket/56999

This ticket was mentioned in ​PR #3571 on ​WordPress/wordpress-develop by ​@mikachan.
2 years ago #2

This renames the Comments template part to 'Comments Template Part', to reduce confusion with the 'Comments' block when viewing both in the inserter.

https://i0.wp.com/user-images.githubusercontent.com/1645628/200033049-03a359ec-8bdd-47ec-8b70-ee4ad784c289.png

Trac ticket: https://core.trac.wordpress.org/ticket/56999

#3 @mukesh27
2 years ago

Thanks @mikachan for ticket and PR. It LGTM and approved.

#4 @mikachan
2 years ago

Thank you, @mukesh27!

#5 @poena
14 months ago

  • Keywords commit added
  • Milestone changed from Awaiting Review to 6.5

This is a name change only and it needs no further testing, moving it to the 6.5 milestone.

#6 @swissspidy
14 months ago

  • Owner set to swissspidy
  • Resolution set to fixed
  • Status changed from new to closed

In 57502:

Twenty Twenty-Three: Rename Comments template part.

This renames the Comments template part to 'Comments Template Part', to reduce confusion with the 'Comments' block when viewing both in the inserter.

Props mikachan, mukesh27, poena.
Fixes #56999.

Note: See TracTickets for help on using tickets.