Non secure links needs to be replaced with the secure ones.

[haritpanchal]

I came across the file where two non-secure links were added even if the secure links are active on the web.

[haritpanchal]

Patch added

[audrasjb]

Thanks for the ticket and patch.
Self assigning for commit.

[audrasjb]

In 54759:

Docs: Replace HTTP links with HTTPS in class-json.php docblocks.

Props haritpanchal.
Fixes #57017.
See #56792.

[audrasjb]

There is a similar link to http://www.opensource.org/licenses/bsd-license.php in class-IXR.php. Would be nice to address them all at once.

[audrasjb]

No need to open a new ticket, we can simply add a PR in this one to address the remaining occurrences.

[audrasjb]

Reopening and converting to a task to address other similar issues.

[audrasjb]

#57027 was marked as a duplicate.

[audrasjb]

#57028 was marked as a duplicate.

[rajeshraval786]

Patch added for same link changes.

[hiren1094]

Patch added for this "https://core.trac.wordpress.org/ticket/57028" tickit

[krunal265]

patch added.

[rudlinkon]

#57029 was marked as a duplicate.

[audrasjb]

@krunal265 Just noting that 57029.patch shouldn't be committed directly to core.

As per #57029, comment 3:

SimplePie is an external library, and this should be reported upstream directly to them: ​https://github.com/simplepie/simplepie

[audrasjb]

In 54775:

Docs: Replace HTTP links with HTTPS in class-pop3.php docblocks and JS vendor readme file.

Props rajeshraval786, hiren1094.
See #57017, #56792.

[itpathsolutions]

Patch added

[itpathsolutions]

@audrasjb

Replaced HTTP links with HTTPS in IRI.php, IPv6.php, class-IXR.php files.

[rudlinkon]

Thank you @itpathsolutions for the patch but you set the version to 6.1 which is incorrect.

[haritpanchal]

@itpathsolutions The patch has been added already.

[itpathsolutions]

Replying to rudlinkon:

Thank you @itpathsolutions for the patch but you set the version to 6.1 which is incorrect.

@rudlinkon There is no any options to choose wordpress version 6.2.

[itpathsolutions]

Replying to haritpanchal:

@itpathsolutions The patch has been added already.

@haritpanchal It's a different patch with different files. We Replaced HTTP links with HTTPS in IRI.php, IPv6.php, class-IXR.php files.

[rudlinkon]

Replying to itpathsolutions:

Replying to rudlinkon:

Thank you @itpathsolutions for the patch but you set the version to 6.1 which is incorrect.

@rudlinkon There is no any options to choose wordpress version 6.2.

Actually, you have to choose the version number where the issue has appeared from.

[itpathsolutions]

Replying to rudlinkon:

Replying to itpathsolutions:

Replying to rudlinkon:

Thank you @itpathsolutions for the patch but you set the version to 6.1 which is incorrect.

@rudlinkon There is no any options to choose wordpress version 6.2.

Actually, you have to choose the version number where the issue has appeared from.

@rudlinkon The issue was reproduced on WordPress version 6.1, that's why we added a version 6.1.

[haritpanchal]

Replying to itpathsolutions: Okay, got it. Thanks!

Replying to haritpanchal:

@itpathsolutions The patch has been added already.

@haritpanchal It's a different patch with different files. We Replaced HTTP links with HTTPS in IRI.php, IPv6.php, class-IXR.php files.

[audrasjb]

Removing version 6.1 as it is not the version the issue was introduced :)

Better to keep it empty since those strings were introduced at various moments.

(see ​this handbook page for more details about the "Version" field)

[rudlinkon]

Replying to audrasjb:

Removing version 6.1 as it is not the version the issue was introduced :)

Better to keep it empty since those strings were introduced at various moments.

(see ​this handbook page for more details about the "Version" field)

Great, thank you @audrasjb

Trac ticket: https://core.trac.wordpress.org/ticket/57017

Trac ticket: https://core.trac.wordpress.org/ticket/57017

@SergeyBiryukov can you plz re-run the job?

Thanks @akramulhasan PR looks good to me.

Thank you so much. You are most welcome!

I restarted failed jobs.

[audrasjb]

Hi there,

Tests are failing for a good reason: the "URL" used as a value for the xmlns attribute inside SVG images shouldn't be changed to https. It's not really a URL, it's a namespace that looks like a URL. It must be written as it, with http and not https.

Hi @audrasjb , thanks for your feedback.
I have made the changes. All the namespace is now HTTP
What should I do now.
I am not sure, should I create another Pull Request or how my changes will be reached in place.

Thank you @akramulhasan for your changes. @audrasjb can you please run the job again?

Thank you @akramulhasan for your changes. @audrasjb can you please run the job again?

Thanks bro

[flixos90]

Removing performance focus here since this appears to be unrelated and rather about security.

[azaozz]

This ticket seems to be about some documentation enhancements, to change http:// to https:// in links. As such it doesn't need to be a "Task", can be committed at any time even during RC :)

[audrasjb]

Replying to itpathsolutions:

@audrasjb

Replaced HTTP links with HTTPS in IRI.php, IPv6.php, class-IXR.php files.

@itpathsolutions sorry but the changes proposed in 57017.diff are on an external library, so this should be proposed upstream on the Requests lib: ​https://github.com/WordPress/Requests

Therefore, this patch is invalid. Thanks for the patch though!

Now, I'll be going through other patches :)

[audrasjb]

@krunal265 57029.patch (Diff API) doesn't look ok to go as it replaces the URL with a 404 one.

Thanks, committed in https://core.trac.wordpress.org/changeset/55355

[audrasjb]

In 55356:

Docs: Replace HTTP with HTTPS in PHP Manual links located in WP_Privacy_Policy_Content class.

Follow-up to [55355].

See #56792, #57017.

Tests are failing because they this changeset is probably touching some files that need to be build.
Also, it misses more occurrences in readme.txt files. It would be nice to propose a new PR, and to attach it to a specific ticket to replace http links with https specifically on bundled themes. @akramulhasan, would you like to propose a new ticket for this, so it can be handled specifically?

Thanks!

Hi @audrasjb , thanks for the update. I will do it asap.

[audrasjb]

As there is currently no patch ready to ship, let's close this as fixed for 6.2 release cycle.

Other occurrences can be addressed in a follow-up ticket during the next release cycle.

Thanks everyone!