#57026 closed task (blessed) (fixed)
Replace instances of "Full site editing" with "Site editor"
Reported by: |
|
Owned by: |
|
---|---|---|---|
Milestone: | 6.1.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Text Changes | Keywords: | has-patch fixed-major i18n-change commit |
Focuses: | Cc: |
Description
As per this announcement, we have to replace the few occurrences of "Full site editing" with "Site editor".
Change History (23)
This ticket was mentioned in PR #3578 on WordPress/wordpress-develop by @audrasjb.
2 years ago
#2
- Keywords has-patch added
This ticket was mentioned in PR #3578 on WordPress/wordpress-develop by @audrasjb.
2 years ago
#3
#4
in reply to:
↑ 1
;
follow-up:
↓ 6
@
2 years ago
Replying to audrasjb:
Milestoning to 6.2 by default, but we may want to ship this with 6.1.1 as the sooner we replace those strings, the better it will be for adoption :)
If this is backported, to either 6.1.1 or another point release, I suggest making it conditional on other string changes. I don't think it justifies needing new language packs on its own.
I know some locales, such as fr.wordpress.org, would be able to act quickly but others may not have the same availability for point releases.
2 years ago
#5
Looks good to me.
-For the theme tag it would be good to create an alias and not only change the label, so that theme developers can use the shorter term.
This also needs to be updated in the api.
#6
in reply to:
↑ 4
@
2 years ago
Replying to peterwilsoncc:
If this is backported, to either 6.1.1 or another point release, I suggest making it conditional on other string changes. I don't think it justifies needing new language packs on its own.
Works for me, but worth noting that [54773] already introduced a new string to branch 6.1 so polyglots team already need to generate a new language package for WP 6.1.1.
#7
@
2 years ago
@audrasjb I returned to make that very same observation. I'm happy if this goes in to 6.1.1 but it's probably best to check in with Jeff and Jon as they're leading the release.
@audrasjb commented on PR #3578:
2 years ago
#8
Good point @carolinan :)
Let's commit this change first so it's ready to ship with 6.1.1 if it's possible.
Then I'll open a Meta Trac ticket to ask for a change in WordPress.org, then we can open a new ticket to change the tag accordingly :)
#9
@
2 years ago
- Keywords commit added
Alright, marking for commit
.
Then I'll ask to consider this for a 6.1.1 backport.
#10
@
2 years ago
- Owner set to audrasjb
- Resolution set to fixed
- Status changed from new to closed
In 54786:
@audrasjb commented on PR #3578:
2 years ago
#11
Committed in https://core.trac.wordpress.org/changeset/54786
#12
@
2 years ago
I think "Hurray! Your theme supports Site Editing with blocks." should be in regular sentence case "Hurray! Your theme supports site editing with blocks." since only Site Editor is the "brand name"?
#15
@
2 years ago
- Keywords fixed-major i18n-change added; commit removed
- Milestone changed from 6.2 to 6.1.1
Reopening for 6.1.1 backport consideration.
#20
@
2 years ago
- Keywords commit added
- Resolution fixed deleted
- Status changed from closed to reopened
I was hoping there was an occurrence of Site Editor
in Core already so that this would be more seamless, but that doesn't seem to be the case.
I think given the recent announcement, though, this makes sense to get out now rather than in 2023.
Feel free to backport the three commits here, @audrasjb.
#23
@
23 months ago
Just wanted to note that the updates to Twenty Twenty-Two in the commits attached to this ticket were not released with 6.1.1, but will be included in the 1.4 release accompanying 6.2. I'm going to include the change in the theme's changelog and link to this ticket, so wanted it to be clear why a link was being made to a 6.1.1 ticket.
Milestoning to 6.2 by default, but we may want to ship this with 6.1.1 as the sooner we replace those strings, the better it will be for adoption :)