Make WordPress Core

Opened 18 months ago

Closed 18 months ago

Last modified 13 months ago

#57026 closed task (blessed) (fixed)

Replace instances of "Full site editing" with "Site editor"

Reported by: audrasjb's profile audrasjb Owned by: audrasjb's profile audrasjb
Milestone: 6.1.1 Priority: normal
Severity: normal Version:
Component: Text Changes Keywords: has-patch fixed-major i18n-change commit
Focuses: Cc:

Description

As per this announcement, we have to replace the few occurrences of "Full site editing" with "Site editor".

Change History (23)

#1 follow-up: @audrasjb
18 months ago

Milestoning to 6.2 by default, but we may want to ship this with 6.1.1 as the sooner we replace those strings, the better it will be for adoption :)

This ticket was mentioned in PR #3578 on WordPress/wordpress-develop by @audrasjb.


18 months ago
#2

  • Keywords has-patch added

#4 in reply to: ↑ 1 ; follow-up: @peterwilsoncc
18 months ago

Replying to audrasjb:

Milestoning to 6.2 by default, but we may want to ship this with 6.1.1 as the sooner we replace those strings, the better it will be for adoption :)

If this is backported, to either 6.1.1 or another point release, I suggest making it conditional on other string changes. I don't think it justifies needing new language packs on its own.

I know some locales, such as fr.wordpress.org, would be able to act quickly but others may not have the same availability for point releases.

@poena commented on PR #3578:


18 months ago
#5

Looks good to me.

-For the theme tag it would be good to create an alias and not only change the label, so that theme developers can use the shorter term.
This also needs to be updated in the api.

#6 in reply to: ↑ 4 @audrasjb
18 months ago

Replying to peterwilsoncc:

If this is backported, to either 6.1.1 or another point release, I suggest making it conditional on other string changes. I don't think it justifies needing new language packs on its own.

Works for me, but worth noting that [54773] already introduced a new string to branch 6.1 so polyglots team already need to generate a new language package for WP 6.1.1.

#7 @peterwilsoncc
18 months ago

@audrasjb I returned to make that very same observation. I'm happy if this goes in to 6.1.1 but it's probably best to check in with Jeff and Jon as they're leading the release.

@audrasjb commented on PR #3578:


18 months ago
#8

Good point @carolinan :)
Let's commit this change first so it's ready to ship with 6.1.1 if it's possible.
Then I'll open a Meta Trac ticket to ask for a change in WordPress.org, then we can open a new ticket to change the tag accordingly :)

#9 @audrasjb
18 months ago

  • Keywords commit added

Alright, marking for commit.

Then I'll ask to consider this for a 6.1.1 backport.

#10 @audrasjb
18 months ago

  • Owner set to audrasjb
  • Resolution set to fixed
  • Status changed from new to closed

In 54786:

Text Changes: Replace "Full site editing" with "Site Editor".

This changeset replaces the various occurrences of "Full site editing" with "Site Editor" as it is the new official name of the feature.

For more background about this change, see https://make.wordpress.org/updates/2022/11/04/site-editor-a-more-user-friendly-name/.

Props audrasjb, peterwilsoncc, poena.
Fixes #57026.

#12 @ocean90
18 months ago

I think "Hurray! Your theme supports Site Editing with blocks." should be in regular sentence case "Hurray! Your theme supports site editing with blocks." since only Site Editor is the "brand name"?

#13 @audrasjb
18 months ago

Ah good point, yes only Site Editor is the brand name, you're right 👍

#14 @audrasjb
18 months ago

In 54787:

Text Changes: Remove capitalization on "site editing".

Follow-up to [54786].

Props ocean90.
See #57026.

#15 @audrasjb
18 months ago

  • Keywords fixed-major i18n-change added; commit removed
  • Milestone changed from 6.2 to 6.1.1

Reopening for 6.1.1 backport consideration.

#16 @Mamaduka
18 months ago

Backporting the string updates into 6.1.1 sounds good to me.

#17 @audrasjb
18 months ago

Ok then I'll replace the @since mention used in wp-admin/includes/theme.php :)

#18 @audrasjb
18 months ago

In 54788:

Text Changes: Update @since mentions for [54786] changes.

This updates the @since mention of get_theme_feature_list() as this changeset is going to be backported to 6.1.1.

Follow-up to [54786].

See #57026.

#19 @audrasjb
18 months ago

Now we are ready to backport it to branch 6.1.

#20 @desrosj
18 months ago

  • Keywords commit added
  • Resolution fixed deleted
  • Status changed from closed to reopened

I was hoping there was an occurrence of Site Editor in Core already so that this would be more seamless, but that doesn't seem to be the case.

I think given the recent announcement, though, this makes sense to get out now rather than in 2023.

Feel free to backport the three commits here, @audrasjb.

#21 @audrasjb
18 months ago

Yeah, same.
Thanks for the double sign-off Jon :)

#22 @audrasjb
18 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 54792:

Text Changes: Replace "Full site editing" with "Site Editor".

This changeset replaces the various occurrences of "Full site editing" with "Site Editor" as it is the new official name of the feature.
For more background about this change, see https://make.wordpress.org/updates/2022/11/04/site-editor-a-more-user-friendly-name/.

Props audrasjb, peterwilsoncc, poena, ocean90, Mamaduka, desrosj.
Fixes #57026.
Merges [54786], [54787], and [54788] to the 6.1 branch.

#23 @desrosj
13 months ago

Just wanted to note that the updates to Twenty Twenty-Two in the commits attached to this ticket were not released with 6.1.1, but will be included in the 1.4 release accompanying 6.2. I'm going to include the change in the theme's changelog and link to this ticket, so wanted it to be clear why a link was being made to a 6.1.1 ticket.

Note: See TracTickets for help on using tickets.