Make WordPress Core

Opened 13 months ago

Last modified 4 months ago

#57032 new defect (bug)

Percent sign in site title leads to signing up new users not working

Reported by: pekkagaiser's profile pekka.gaiser Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 6.0.3
Component: Login and Registration Keywords: needs-testing
Focuses: multisite Cc:

Description

When a web site title contains a percent sign, e.g.

Brand name - 100% organic

the process of signing up a new user in /wp-admin/user-new.php will fail with a fatal error, probably because the percent sign is interpreted as a placeholder by sprintf() in /wp-includes/ms-functions.php around line 1105:

Fatal error: Uncaught ArgumentCountError: 3 arguments are required, 2 given in
(...)/sites/wheaty_v3/htdocs/wp-includes/ms-functions.php:1105Stack
trace: #© (...)/htdocs/wp-includes/ms-functions.php(1105):
sprintf(' Hallo, Indu wurde..
, 'https://www.whe...#1
(...)/htdocs/wp-includes/class-wp-hook.php(307):
wpmu_signup_user_notification('(...)','(...)..
'36db891bc11cbbc..
, Array) #2
(...)/htdocs/wp-includes/class-wp-hook.php(331):
WP_Hook->apply_filters(",Array)#3(...)/htdocs/wp-
includes/plugin.php(476):WP_Hook->do_action(Array)#4
/(...)/htdocs/wp-includes/ms-functions.php(892):
do action('after_signup_us...,
'(...)', '(...)
'36db891bc11cbbc..., Array) #5
(...)/wheaty_v3/htdocs/wp-admin/user-new.php(226):
wpmu_signup_user('oliver2', 'technik@hansetr..
, Array) #6 {main} thrown in
/(...)/htdocs/wp-includes/ms-functions.php on line
1105

Presumably, the web site title needs to be escaped somewhere in the apply_filters() call.

Attachments (1)

wp.jpg (783.4 KB) - added by pekka.gaiser 13 months ago.

Download all attachments as: .zip

Change History (5)

#1 @sabernhardt
13 months ago

  • Focuses multisite added

#2 follow-up: @kowsar89
13 months ago

Works fine from my side. Which PHP version you are using?

Version 0, edited 13 months ago by kowsar89 (next)

#3 in reply to: ↑ 2 @pekka.gaiser
13 months ago

Replying to kowsar89:

Works fine from my side(WP-v6.1, PHP-v7.4.30). Which PHP version you are using?

Huh! Strange.
PHP is 8.1.7.

I can definitely reproduce it (if I add the % in the site title, it breaks, if I remove it, it works).
But have lots of plugins and customizations running.
Will try to reproduce on a completely clean WP install if I can.

Last edited 13 months ago by pekka.gaiser (previous) (diff)

@pekka.gaiser
13 months ago

#4 @rajinsharwar
4 months ago

  • Keywords needs-testing added

Hey @pekkagaiser, thanks for your ticket. I have tried to reproduce as well in a multi-site environment with PHP version 8+. But, I didn't encounter any Fatal errors. Let us know if you can replicate this in a clean install or not. By then, would really appreciate any testing from other peeps.

Note: See TracTickets for help on using tickets.