WordPress.org
Get WordPress

Make WordPress Core

Opened 3 years ago

Closed 3 years ago

Last modified 3 years ago

#57033 closed defect (bug) (fixed)

Document the globals in validate_column(), get_sql_for_clause() and build_time_query().

Reported by: upadalavipul's profile upadalavipul Owned by: sergeybiryukov's profile SergeyBiryukov
Milestone: 6.2 Priority: normal
Severity: normal Version: 6.2
Component: Date/Time Keywords: has-patch
Focuses: docs Cc:

Description

I am checking for all function commenting details for a good & better understanding of the code and in which I have found one file that needs improvement. please check the below details.
File Name: wp-includes/class-wp-date-query.php
Function Name: validate_column(), get_sql_for_clause() and build_time_query()

Attachments (1)

57033.patch​ (1.1 KB) - added by upadalavipul 3 years ago.

Download all attachments as: .zip

Change History (4)

@upadalavipul
3 years ago

#1 @SergeyBiryukov
3 years ago

  • Keywords has-patch added
  • Milestone changed from Awaiting Review to 6.2

Thanks for the patch!

#2 @SergeyBiryukov
3 years ago

  • Owner set to SergeyBiryukov
  • Resolution set to fixed
  • Status changed from new to closed

In 54765:

Docs: Document the usage of $wpdb global in WP_Date_Query methods.

Follow-up to [25139], [29933], [38280], [38768].

Props upadalavipul.
Fixes #57033.

#3 @SergeyBiryukov
3 years ago

  • Component changed from Upgrade/Install to Date/Time
Note: See TracTickets for help on using tickets.