Make WordPress Core

Changes between Initial Version and Version 1 of Ticket #57035, comment 13


Ignore:
Timestamp:
03/28/2023 09:41:48 AM (13 months ago)
Author:
Rarst
Comment:

Legend:

Unmodified
Added
Removed
Modified
  • Ticket #57035, comment 13

    initial v1  
    1 As reported in #57998 the fix is faulty because `gmt_offset` can be a float value for partial-hour offsets (e.g. +11:30). The product of offset and hour in seconds should be integer (as expressed by original logic), but the offset should not.
     1As reported in #57998 the fix is faulty because `gmt_offset` can be a float-like value for partial-hour offsets (e.g. +11:30). The product of offset and hour in seconds should be integer (as expressed by original logic), but the offset should not.
    22
    33Probably needs unit test for the case, if it slipped through the existing ones.