Make WordPress Core

Opened 2 years ago

Closed 2 years ago

Last modified 2 years ago

#57040 closed defect (bug) (fixed)

Translation missing for text "N/A"

Reported by: kowsar89's profile kowsar89 Owned by: audrasjb's profile audrasjb
Milestone: 6.2 Priority: normal
Severity: normal Version:
Component: Networks and Sites Keywords: has-patch commit
Focuses: multisite, ui-copy Cc:

Description

Seems like translation function could be added in this string:

} else {
    echo 'N/A';
}

Change History (10)

This ticket was mentioned in PR #3583 on WordPress/wordpress-develop by kowsar89.


2 years ago
#1

  • Keywords has-patch added

#2 @SergeyBiryukov
2 years ago

  • Component changed from General to Networks and Sites
  • Focuses multisite added
  • Milestone changed from Awaiting Review to 6.2

Hi there, welcome to WordPress Trac! Thanks for the report.

I think you're right, this string should be translatable.

For anyone looking at the ticket, the string is displayed in the choose_primary_blog() function when the user does not belong to any sites.

#3 @audrasjb
2 years ago

Yep, sounds good to me as well.

Maybe we could also replace this abbreviation with a more detailed wording, for better accessibility and to make it more user friendly?

N/A could be replaced with "Not applicable" or, maybe better, "Not available".

#4 @audrasjb
2 years ago

  • Version trunk deleted

#6 @audrasjb
2 years ago

Yeah I think "Not available" would be our best bet for this one 👍

#7 @kowsar89
2 years ago

I have updated the PR, replaced text "N/A" with "Not available"

#8 @audrasjb
2 years ago

  • Focuses ui-copy added
  • Keywords commit added
  • Owner set to audrasjb
  • Status changed from new to accepted

Thanks for the update. Marking for commit.

#9 @audrasjb
2 years ago

  • Resolution set to fixed
  • Status changed from accepted to closed

In 54832:

Networks and Sites: Replace "N/A" with "Not applicable" in choose_primary_blog()

This changeset replaces "N/A" with "Not applicable" in the choose_primary_blog() function. It also makes the text string translatable.

Props kowsar89, SergeyBiryukov, audrasjb, mukesh27.
Fixes #57040.

Note: See TracTickets for help on using tickets.