#57052 closed enhancement (fixed)
Revise use of "we" in comments to second person point of view
Reported by: | ironprogrammer | Owned by: | audrasjb |
---|---|---|---|
Milestone: | 6.3 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Text Changes | Keywords: | has-patch |
Focuses: | Cc: |
Description
Adjusts comments using "we" (first person point of view) to preferred second person point of view, as outlined in Make/Docs:
- https://make.wordpress.org/docs/style-guide/language-grammar/grammatical-person/
- https://make.wordpress.org/docs/handbook/documentation-team-handbook/handbooks-style-and-formatting-guide/
Follow-up to #46057.
Change History (26)
This ticket was mentioned in PR #3593 on WordPress/wordpress-develop by @ironprogrammer.
2 years ago
#1
- Keywords has-patch added
This ticket was mentioned in PR #3595 on WordPress/wordpress-develop by @ironprogrammer.
2 years ago
#2
DRAFT -- work in progress
- Replaces first-person usage of "we" with second person point of view.
- Also makes small clarification adjustments where voice is much too casual or lacks clear context, especially for non-native English speakers.
This PR focuses on files in the WordPress wp-admin
directory.
Trac ticket: https://core.trac.wordpress.org/ticket/57052
#3
follow-up:
↓ 5
@
2 years ago
Alot of the casual language is very intentional and should not be removed.
@ironprogrammer commented on PR #3593:
2 years ago
#4
Just one suggestion that I'm not precious about. LGTM with or without the suggestion 👍
Thanks, @costdev! Change committed.
#5
in reply to:
↑ 3
@
2 years ago
Thanks, jorbin:
Alot of the casual language is very intentional and should not be removed.
Understood, and I agree. My saying "much too casual" in the PR description was too euphemistic. So to better describe what I meant, here's an example where the internal dialog-style may confuse things 😁:
Original (introduced):
/*
* We're going to redirect to setup-config.php. While this shouldn't result
* in an infinite loop, that's a silly thing to assume, don't you think? If
* we're traveling in circles, our last-ditch effort is "Need more help?"
*/
Revised (ba67ff2):
// Redirect to setup-config.php.
#6
@
2 years ago
- Milestone changed from Awaiting Review to 6.2
Thanks for the ticket! The suggested edits look good to me at a glance.
@ironprogrammer commented on PR #3593:
2 years ago
#7
Thanks for the reviews, @SergeyBiryukov! I appreciate it!
@SergeyBiryukov commented on PR #3593:
2 years ago
#9
Thanks for the PR! Merged in r54866.
This ticket was mentioned in Slack in #core by mukeshpanchal27. View the logs.
22 months ago
#11
@
22 months ago
- Keywords reporter-feedback added
This ticket was discussed in the recent bug scrub.
One PR has been merged, but the other is still in draft. @ironprogrammer's second PR still needs some work? Do you think it will be ready for review before beta?
Props to @costdev
This ticket was mentioned in Slack in #core by costdev. View the logs.
21 months ago
#13
@
21 months ago
- Keywords reporter-feedback removed
- Resolution set to fixed
- Status changed from new to closed
This ticket was discussed during the bug scrub. PR 3595 will not be ready for 6.2 Beta 1 on February 7th, and can be addressed in a follow-up ticket in a future release.
Closing this ticket as fixed
in 6.2.
Additional props: @audrasjb
This ticket was mentioned in PR #4269 on WordPress/wordpress-develop by @majaloncar.
19 months ago
#14
#15
@
19 months ago
We are at WordCamp Switzerland and during the contributor day JB Ausdras identified the bug and we as the team resolved it.
#16
@
19 months ago
- Milestone changed from 6.2 to 6.3
- Resolution fixed deleted
- Status changed from closed to reopened
Indeed wee missed (at least) one occurrence!
Reopening so we can hopefully fix this for WP 6.3 :)
This ticket was mentioned in PR #4270 on WordPress/wordpress-develop by leaoriol.
19 months ago
#17
#18
@
19 months ago
We are at WordCamp Switzerland and during the contributor day. JB Ausdras identified the bug and we as the team resolved it.
This ticket was mentioned in PR #4271 on WordPress/wordpress-develop by @annebovelett.
19 months ago
#19
#20
@
19 months ago
I'm at WordCamp Switzerland, at the contributor day, and FINALLY learned how to do this. :-)
#21
@
19 months ago
Note: We used this ticket for learning purpose as part of WordCamp Switzerland, a big thank you to our three heroes of the day! @annebovelett, @majaloncar @leamcaleese :)
#22
@
19 months ago
I honestly think tickets like these should be one of the last commits no? What good would a commit now do if later in the 6.3 dev cycle another we is added...?
#23
@
19 months ago
- Owner set to audrasjb
- Resolution set to fixed
- Status changed from reopened to closed
In 55646:
@audrasjb commented on PR #4271:
19 months ago
#24
Thanks! Committed in https://core.trac.wordpress.org/changeset/55646
@audrasjb commented on PR #4270:
19 months ago
#25
Thanks! Committed in https://core.trac.wordpress.org/changeset/55646
@audrasjb commented on PR #4269:
19 months ago
#26
Thanks! Committed in https://core.trac.wordpress.org/changeset/55646
This PR focuses on files in the WordPress root directory.
Trac ticket: https://core.trac.wordpress.org/ticket/57052