WordPress.org
Get WordPress

Make WordPress Core

Opened 4 years ago

Closed 4 years ago

Last modified 4 years ago

#57058 closed defect (bug) (fixed)

Document the globals in unregister_taxonomy() and wp_term_is_shared().

Reported by: upadalavipul Owned by: audrasjb
Priority: normal Milestone: 6.2
Component: Taxonomy Version:
Severity: normal Keywords: has-patch commit
Cc: Focuses: docs

Description

function commenting details needs to improve.

File Name: wp-includes/taxonomy.php
Function Name: unregister_taxonomy() and wp_term_is_shared()

Attachments (1)

57058.patch​ (728 bytes ) - added by upadalavipul 4 years ago.

Download all attachments as: .zip

Change History (6)

@upadalavipul
4 years ago

#1 @mukesh27
4 years ago

  • Component General → Taxonomy
  • Keywords has-patch added

Thanks @upadalavipul for ticket and patch!

Adding document for wp_term_is_shared() good.

global WP added when unregister_taxonomy() introduce in #35227.

#2 @mukesh27
4 years ago

  • Milestone Awaiting Review → 6.2

The global WP remove in https://core.trac.wordpress.org/changeset/38747.

Moving to 6.2

#3 @audrasjb
4 years ago

  • Keywords commit added
  • Version trunk

The patch looks good to me. Self assigning for commit.

#4 @audrasjb
4 years ago

  • Owner set to audrasjb
  • Resolution → fixed
  • Status new → closed

In 54794:

Docs: Improve globals documentation in unregister_taxonomy() and wp_term_is_shared().

Props upadalavipul, mukesh27.
Fixes #57058.
See #56792.

#5 @SergeyBiryukov
4 years ago

In 54810:

Coding Standards: Declare $wp_taxonomies global at the top of unregister_taxonomy().

This brings some consistency with how the global is declared in other taxonomy functions.

Follow-up to [36243], [38747], [54794].

See #57058.

Note: See TracTickets for help on using tickets.