#57075 closed defect (bug) (fixed)
Fluid typography fixes for 6.1.1
Reported by: | desrosj | Owned by: | desrosj |
---|---|---|---|
Milestone: | 6.1.1 | Priority: | normal |
Severity: | normal | Version: | |
Component: | Editor | Keywords: | has-patch has-unit-tests fixed-major |
Focuses: | Cc: |
Description
This ticket is for tracking fluid typography bug fixes independent from dependencies (within PHP code).
Change History (6)
This ticket was mentioned in PR #3602 on WordPress/wordpress-develop by @ramonopoly.
23 months ago
#1
- Keywords has-unit-tests added
#2
@
23 months ago
- Owner set to desrosj
- Resolution set to fixed
- Status changed from new to closed
In 54823:
Note: See
TracTickets for help on using
tickets.
Backporting changes in https://github.com/WordPress/gutenberg/pull/45536
Trac ticket: https://core.trac.wordpress.org/ticket/57075
### Updates to the fluid typography rules:
>16px
. This applies to custom values from the editor or single-value theme.json styles. Font sizes below this will not be clamped.fluid.min
value has been specified, the lower bound rule of>16px
won't be enforced on this value. Presets with a fluid object therefore, give precedence to theme author's values.fluid.max
but there isfluid.min
, use the incoming"size"
value as the max.fluid.min
but there is afluid.max
, usesize * min_size_factor
as the min. Here we do enforce the lower bound rule of>16px
, because Gutenberg is computing the min value. This is consistent with the way we calculate minimum sizes for single or custom values.### Testing
Using theme 2023
Add some text blocks to the editor, apply presets and custom sizes, and ensure they appear as they should in the editor and frontend at various viewport widths.
The size value should act at the upper bound of any clamp value.
Custom font sizes <=14px will not be clamped.
Please test by playing around with: