Opened 2 years ago
Closed 2 years ago
#57080 closed defect (bug) (fixed)
Add `wp-includes/blocks/comments-query-loop` to `$_old_files`
Reported by: | SergeyBiryukov | Owned by: | desrosj |
---|---|---|---|
Milestone: | 6.1.1 | Priority: | normal |
Severity: | normal | Version: | 6.1 |
Component: | Upgrade/Install | Keywords: | has-patch commit fixed-major |
Focuses: | Cc: |
Description
As noticed by @azaozz on Slack, there is an empty wp-includes/blocks/comments-query-loop directory in SVN and in the 6.1 release.
As noted by @jorbin, it looks like the directory was supposed to be deleted in [54257], which removed the block.json
file from it, but not the directory itself.
Since the directory was not deleted in that commit, it was also missed from being added to $_old_files
in [54730], which included wp-includes/blocks/post-comments
, but not wp-includes/blocks/comments-query-loop
.
The latter directory should be removed from SVN and added to the array too.
Attachments (1)
Change History (6)
#2
in reply to:
↑ 1
@
2 years ago
Replying to desrosj:
As for including this in 6.1.1, I think that this could be considered a procedural item that we can include without having to create an additional RC.
Agreed, that's what I was thinking too.
#3
@
2 years ago
- Owner set to desrosj
- Resolution set to fixed
- Status changed from new to closed
In 54836:
57080.diff looks good to commit to me.
As for including this in 6.1.1, I think that this could be considered a procedural item that we can include without having to create an additional RC.
@SergeyBiryukov what are your thoughts on that?