Make WordPress Core

#57080 closed defect (bug) (fixed)

Add `wp-includes/blocks/comments-query-loop` to `$_old_files`

Reported by: sergeybiryukov's profile SergeyBiryukov Owned by: desrosj's profile desrosj
Milestone: 6.1.1 Priority: normal
Severity: normal Version: 6.1
Component: Upgrade/Install Keywords: has-patch commit fixed-major
Focuses: Cc:

Description

As noticed by @azaozz on Slack, there is an empty wp-includes/blocks/comments-query-loop directory in SVN and in the 6.1 release.

As noted by @jorbin, it looks like the directory was supposed to be deleted in [54257], which removed the block.json file from it, but not the directory itself.

Since the directory was not deleted in that commit, it was also missed from being added to $_old_files in [54730], which included wp-includes/blocks/post-comments, but not wp-includes/blocks/comments-query-loop.

The latter directory should be removed from SVN and added to the array too.

Attachments (1)

57080.diff (490 bytes) - added by SergeyBiryukov 19 months ago.

Download all attachments as: .zip

Change History (6)

#1 follow-up: @desrosj
19 months ago

  • Keywords commit added

57080.diff looks good to commit to me.

As for including this in 6.1.1, I think that this could be considered a procedural item that we can include without having to create an additional RC.

@SergeyBiryukov what are your thoughts on that?

#2 in reply to: ↑ 1 @SergeyBiryukov
19 months ago

Replying to desrosj:

As for including this in 6.1.1, I think that this could be considered a procedural item that we can include without having to create an additional RC.

Agreed, that's what I was thinking too.

#3 @desrosj
19 months ago

  • Owner set to desrosj
  • Resolution set to fixed
  • Status changed from new to closed

In 54836:

Upgrade/Install: Delete the comments-query-loop folder in wp-includes/blocks.

This properly deletes the now empty src/wp-includes/blocks/comments-query-loop directory and adds that directory to the $_old_files array.

The files in this directory were removed in [54257], but the directory was not marked as deleted in SVN.

Props azaozz, jorbin, SergeyBiryukov.
Fixes #57080.

#4 @desrosj
19 months ago

  • Keywords fixed-major added
  • Resolution fixed deleted
  • Status changed from closed to reopened

Reopening to backport.

#5 @desrosj
19 months ago

  • Resolution set to fixed
  • Status changed from reopened to closed

In 54837:

Upgrade/Install: Delete the comments-query-loop folder in wp-includes/blocks.

This properly deletes the now empty src/wp-includes/blocks/comments-query-loop directory and adds that directory to the $_old_files array.

The files in this directory were removed in [54257], but the directory was not marked as deleted in SVN.

Props azaozz, jorbin, SergeyBiryukov.
Merges [54836] to the 6.1 branch.
Fixes #57080.

Note: See TracTickets for help on using tickets.