Make WordPress Core

Opened 7 months ago

Last modified 7 hours ago

#57087 new defect (bug)

Twenty Twenty: Button text is not visible in footer widget

Reported by: mayur8991's profile mayur8991 Owned by:
Milestone: Awaiting Review Priority: normal
Severity: normal Version: 6.2
Component: Bundled Theme Keywords: has-screenshots has-patch needs-testing
Focuses: css Cc:

Description

  • Choose Twenty Twenty Theme
  • Activate theme
  • Go to widget section
  • add button in footer widget and add texts then save it

in frontend that button text is not visible

Attachments (4)

download.png (80.9 KB) - added by mayur8991 7 months ago.
added screenshot for better understanding
57087.diff (1.6 KB) - added by itpathsolutions 7 months ago.
Patch file added 57087
before patch.jpg (102.4 KB) - added by nithins53 7 months ago.
Before Patch
after patch.jpg (111.6 KB) - added by nithins53 7 months ago.

Download all attachments as: .zip

Change History (11)

@mayur8991
7 months ago

added screenshot for better understanding

@itpathsolutions
7 months ago

Patch file added 57087

#1 @itpathsolutions
7 months ago

  • Keywords has-patch added

Css issue
you can remove .footer-widgets a from function.php line no 755
OR
you can add custom css for button color
Ex:
.widget.widget_block .wp-element-button{color:#ffffff;}

Last edited 7 months ago by itpathsolutions (previous) (diff)

@nithins53
7 months ago

Before Patch

#2 @nithins53
7 months ago

I was able to reproduce the issue. Tested the patch and it works fine. Not sure if it is the right way.

Last edited 7 months ago by nithins53 (previous) (diff)

#3 @sabernhardt
7 months ago

  • Component changed from Themes to Bundled Theme
  • Focuses css added
  • Keywords needs-testing added
  • Summary changed from Twenty Twenty Theme - Button texts is not visible in footer widget to Twenty Twenty: Button text is not visible in footer widget
  • Version 6.1 deleted

The .footer-widgets a selector has been in the theme since PR 447. However, links have a default color regardless of location, so this might be safe to remove. This would need testing with many different links in widgets.

One quirk is that changing the Primary (or accent) color in the Customizer will turn the button text color to white. This color continues to apply when switching back to the default Primary color.

.header-footer-group .wp-block-button:not(.is-style-outline) .wp-block-button__link {
  color: #ffffff;
}

In WordPress 6.0, the button text was also pink, unless the link was visited earlier. (The editor styles had set a white color for the :visited state.)

#4 @arafatjamil01
2 months ago

  • Version set to 6.2

I have applied the patch in svn and tested it with WordPress 6.2, the patch works perfectly.

#5 @thakordarshil
5 weeks ago

Patch works fine in WordPress 6.2
when theme will be available with the patch ?? @sabernhardt

Last edited 4 weeks ago by thakordarshil (previous) (diff)

This ticket was mentioned in Slack in #core by mayur8991. View the logs.


13 days ago

#7 @pooja1210
7 hours ago

Hi

Test report for - https://core.trac.wordpress.org/attachment/ticket/57087/57087.diff patch

Environment:
WordPress - V6.2.2
Theme - Twenty Twenty
Os: Mac
Browser: Chrome

Expected Result: The button text added from the widget should be visible on the frontend ☑️

Before Screenshot:
Backend widget - https://prnt.sc/i6eLFO3PLq3G
Frontend Footer - https://prnt.sc/T3D0YgtcnP3x

After Screenshot:
Backend widget - https://prnt.sc/i6eLFO3PLq3G
Frontend Footer - https://prnt.sc/XeoTFpPVhZvS

Thanks!

Note: See TracTickets for help on using tickets.