Make WordPress Core

#57092 closed defect (bug) (wontfix)

URL should be translatable in 'customize.php'

Reported by: monzuralam's profile monzuralam Owned by:
Milestone: Priority: normal
Severity: normal Version:
Component: Customize Keywords: has-patch close
Focuses: administration, coding-standards Cc:

Description

File path: src/wp-admin/customize.php
Here URL translation is missing ( Line: 243 ).
But in the other file ([options-reading.php]), where use proper translation ( Line: 170 ).
We need to do the same too.
Thanks.

Change History (6)

This ticket was mentioned in PR #3611 on WordPress/wordpress-develop by @monzuralam.


19 months ago
#1

  • Keywords has-patch added; needs-patch removed

Trac ticket: #57092

#2 @SergeyBiryukov
19 months ago

  • Keywords close added

Hi there, welcome back to WordPress Trac!

The string uses the _e() function, so it is already translatable as a whole, including the URL.

Some URLs can indeed be translated separately if they are used in more than one place. However, this does not seem to be the case here.

Searching for <a href=".*">Documentation in other core files, there are 72 matches in 51 files, so this is an established pattern and there does not appear to be a need to change this string.

This ticket was mentioned in PR #3641 on WordPress/wordpress-develop by @monzuralam.


18 months ago
#3

Trac ticket: 57092

@rudlinkon commented on PR #3641:


18 months ago
#4

Thanks to your PR you can escape the $label variable also.

@SergeyBiryukov commented on PR #3641:


18 months ago
#5

Thanks for the PR! Merged in r54857.

#6 @desrosj
17 months ago

  • Milestone Awaiting Review deleted
  • Resolution set to wontfix
  • Status changed from new to closed
  • Version trunk deleted

The linked PR seems to be for #57133 and not this ticket specifically. Since there's been no evidence showing the feedback above is inaccurate, I'm going to close this out. Discussion can always continue on a closed ticket, and if new reasoning is presented this can be reopened.

Note: See TracTickets for help on using tickets.